Skip to content

Conversation

dreambeyondorange
Copy link
Contributor

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #2384 (251475c) into release-3.7 (485e2a9) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-3.7    #2384   +/-   ##
============================================
  Coverage        70.34%   70.34%           
============================================
  Files               13       13           
  Lines             1851     1851           
============================================
  Hits              1302     1302           
  Misses             549      549           
Flag Coverage Δ
unittests 70.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dreambeyondorange dreambeyondorange enabled auto-merge (squash) July 25, 2023 02:16
Copy link
Contributor

@gmarciani gmarciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected many more changes than just these two files. See example of version bump: https://github.com/aws/aws-parallelcluster-cookbook/pull/2383/files

@dreambeyondorange
Copy link
Contributor Author

I expected many more changes than just these two files. See example of version bump: https://github.com/aws/aws-parallelcluster-cookbook/pull/2383/files

I did as well. But most of the bump script uses the short version and this aligns with previous beta bumps https://github.com/aws/aws-parallelcluster-cookbook/pull/2027/files. I don't see the system_tests/ dir any longer so I don't think that change is relevant

@dreambeyondorange dreambeyondorange merged commit 1cf8197 into aws:release-3.7 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants