Move the NFS config file override from the setup action to configure via override_server_template #2391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…via override_server_template The override_server_template function runs during bootstrapping to set the parameter needed for the OS specific config file. The setup action works locally since that action runs during local tests, but does not work during bootstrapping when the node attributes from the setup action are not present
Codecov Report
@@ Coverage Diff @@
## release-3.7 #2391 +/- ##
============================================
Coverage 70.34% 70.34%
============================================
Files 13 13
Lines 1851 1851
============================================
Hits 1302 1302
Misses 549 549
Flags with carried forward coverage won't be shown. Click here to find out more. |
enrico-usai
previously approved these changes
Aug 3, 2023
|
|
||
| action_class do | ||
| def override_server_template | ||
| node.default['nfs']['config']['server_template'] = '/etc/nfs.conf.d/parallelcluster-nfs.conf' |
There was a problem hiding this comment.
Probably the alternative was to move this override outside of the action class, to be "global".
dreambeyondorange
force-pushed
the
release-3.7
branch
from
bf58c7a to
9e99bff
Compare
enrico-usai
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The override_server_template function runs during bootstrapping to set the parameter needed for the OS specific config file. The setup action works locally since that action runs during local tests, but does not work during bootstrapping when the node attributes from the setup action are not present.
Description of changes
Tests
nfs_headnodelocally with kitchenChecklist
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.