Skip to content

Conversation

dreambeyondorange
Copy link
Contributor

Until now ulimit -Sn was used in the config step to confirm the changes in the install step are reflected in the running OS. This is no longer working in Ubuntu 22 because for whatever reason, the session that is created for Ubuntu 22 doesn't have the changes reflected, even though the files are in place. After launching an instance from the AMI however, the changes are there. To improve this test, we need to move it to the install step and check it immediately by switching users and forcing the loading of the limits.

Tests

  • Tested with kitchen test suites using the install_users controls
  • tested platform-install users for all OSes

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

… to the config

Until now ulimit -Sn was used in the config step to confirm the changes in the install
step are reflected in the running OS.  This is no longer working in Ubuntu 22 because
for whatever reason, the session that is created for Ubuntu 22 doesn't have the
changes reflected, even though the files are in place.  After launching an instance
from the AMI however, the changes are there.  To improve this test, we need to move
it to the install step and check it immediately by switching users and forcing the
loading of the limits.
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #2393 (e56f02f) into release-3.7 (6881d0f) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-3.7    #2393   +/-   ##
============================================
  Coverage        70.34%   70.34%           
============================================
  Files               13       13           
  Lines             1851     1851           
============================================
  Hits              1302     1302           
  Misses             549      549           
Flag Coverage Δ
unittests 70.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dreambeyondorange dreambeyondorange enabled auto-merge (squash) August 3, 2023 17:44
@dreambeyondorange dreambeyondorange merged commit ead3ee1 into aws:release-3.7 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants