[Bugfix] Fix logic in function are_queues_updated? #3006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function was assuming to be called only during cluster update, leading to cluster creation failure if it gets called on cluster creation. The reason is that it was assuming that the file containing the previous cluster config always exists, which is not the case on cluster creation.
gmarciani
force-pushed
the
wip/mgiacomo/3140/fix-queue-updated-condition-0812-2
branch
from
1cd0072 to
e43e215
Compare
himani2411
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix logic in function are_queues_updated?
The function was assuming to be called only during cluster update, leading to cluster creation failure if it gets called on cluster creation.
The reason is that it was assuming that the file containing the previous cluster config always exists, which is not the case on cluster creation.
This bug was not causing any impact because the function is actually called only during cluster update. However, in #2996 we needed to call it on cluster creation causing cluster creation failure.
Tests
test_update_slurmBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.