Skip to content

Conversation

himani2411
Copy link
Contributor

@himani2411 himani2411 commented Aug 14, 2025

Description of changes

  • Solve the update failures by defining when to update topology.conf only if p6egb200_block_sizes is not nil.
  • Add a default value of p6egb200_block_sizes as nil

Tests

  • Unit Test
  • Successfully created a cluster and force updated the cluster.
DevSettings:
 Cookbook:
   ChefCookbook: https://github.com/himani2411/aws-parallelcluster-cookbook/tarball/slurm-topo-update-fix

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 requested review from a team as code owners August 14, 2025 23:26
@himani2411 himani2411 added the 3.x label Aug 14, 2025
@himani2411 himani2411 enabled auto-merge (squash) August 15, 2025 00:57
@himani2411 himani2411 merged commit a2651f4 into aws:develop Aug 15, 2025
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants