Is AWS_CUSTOM_MEMORY_MANAGEMENT still to be used?

[magnushakansson]

Confirm by changing [ ] to [x] below:

• I've gone though Developer Guide and API reference
• I've searched for previous similar issues and didn't find any solution

Platform/OS/Hardware/Device
What are you running the sdk on?
Linux

Describe the question
There seems to be some inconsistency in the documentation and unclarity in how to configure custom memory management.

The code example in page https://sdk.amazonaws.com/cpp/api/LATEST/md__docs__memory__management.html refer to the define AWS_CUSTOM_MEMORY_MANAGEMENT but in the latest code the define is USE_AWS_MEMORY_MANAGEMENT (https://sdk.amazonaws.com/cpp/api/LATEST/_a_w_s_allocator_8h_source.html).

The commit 80a6407 changed it in all places in the code except in the file

aws-sdk-cpp/aws-cpp-sdk-core/source/http/curl/CurlHttpClient.cpp

Line 25 in c4e89e4

#ifdef AWS_CUSTOM_MEMORY_MANAGEMENT

.

Is the intentional and you are still supposed to set AWS_CUSTOM_MEMORY_MANAGEMENT when building the SDK (and using it?) as described in the documentation?

[KaibaLopez]

Hi @magnushakansson ,
Thanks for pointing this out to us, it seems like this is something we have just overlooked. But to answer your question no it should not be used anymore.

[github-actions]

Greetings! Sorry to say but this is a very old issue that is probably not getting as much attention as it deservers. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.