Skip to content

Conversation

RanVaknin
Copy link
Contributor

  1. fixes grep -q "<dependency>.*$MODULE_NAME</dependency>" since it doesnt account for mult-line xml code blocks like:
<dependency>
    <groupId>software.amazon.awssdk</groupId>
    <artifactId>utils-lite</artifactId>
    <version>${awsjavasdk.version}</version>
</dependency>

Changed to grep -q "<artifactId>$MODULE_NAME</artifactId>" , the same validation we have for the bom file.

  1. Adds new validations needed for maven central (meta xml tags like name,description and url). This is is super important because it will fail to publish otherwise. We ideally want to catch this stuff in our CI.

@RanVaknin RanVaknin requested a review from a team as a code owner September 4, 2025 23:15
Copy link

sonarqubecloud bot commented Sep 5, 2025

@RanVaknin RanVaknin enabled auto-merge September 5, 2025 16:28
@RanVaknin RanVaknin added this pull request to the merge queue Sep 11, 2025
Merged via the queue into master with commit b2bd265 Sep 11, 2025
45 of 46 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants