feat: support per-request region and service override in signer #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
- Coverage 79.69% 79.65% -0.05%
==========================================
Files 302 296 -6
Lines 11402 11392 -10
Branches 2438 2435 -3
==========================================
- Hits 9087 9074 -13
- Misses 2315 2318 +3
Continue to review full report at Codecov.
|
trivikr
approved these changes
Aug 18, 2020
| signingService, | ||
| } = options; | ||
| const credentials = await this.credentialProvider(); | ||
| const region = signingRegion || (await this.regionProvider()); |
There was a problem hiding this comment.
Use Nullish coalescing operator (??)?
Suggested change
| const region = signingRegion || (await this.regionProvider()); | |
| const region = signingRegion ?? (await this.regionProvider()); |
Ditto on other places when || is used: 137, 178, 180 etc
|
The codebuild succeeds after retry. See log |
trivikr
approved these changes
Aug 19, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The PR makes change to SigV4 signer to support per-request region and service override. Specifically, users can specify
signingRegionandsigningServicewhen signing a request, string, or event. ThesigningRegionandsigningServicewill override theregionandserviceconfiguration specified in SigV4 constructor. The override is only effective for one sign invocation.In the
@aws-sdk/middleware-signing, the signing middleware will inspect the value in theHandlerExecutionContextlooking forsigning_regionandsigning_servicevalue. If the values are set by previous middleware, it mean the signer should use a different signing region or signing service for the specified request. So the middleware will call thesign()with the overriden region or service.This change is useful in infering region or signing service from the operation parameters, e.g. ARN supplied in s3 bucket parameter
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.