-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: statically import credential-provider-node in clients used from credentials #6027
Merged
trivikr
merged 12 commits into
aws:main
from
trivikr:sts-static-import-credential-provider-node
Apr 26, 2024
Merged
chore: statically import credential-provider-node in clients used from credentials #6027
trivikr
merged 12 commits into
aws:main
from
trivikr:sts-static-import-credential-provider-node
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
changed the title
chore(client-sts): statically import credential-provider-node
chore: statically import credential-provider-node in clients used from credentials
Apr 25, 2024
trivikr
force-pushed
the
sts-static-import-credential-provider-node
branch
3 times, most recently
from
April 26, 2024 16:47
8bf01be
to
3dee0da
Compare
trivikr
commented
Apr 26, 2024
trivikr
force-pushed
the
sts-static-import-credential-provider-node
branch
from
April 26, 2024 19:56
1da4df2
to
5b7b4a0
Compare
This reverts commit 8cde839.
The types were being emitted without ts-expect-error
trivikr
force-pushed
the
sts-static-import-credential-provider-node
branch
from
April 26, 2024 20:28
5b7b4a0
to
441151a
Compare
siddsriv
approved these changes
Apr 26, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-5156
Description
Statically imports
@aws-sdk/credential-provider-node
in clients used from credentials, i.e. client-sts and client-sso-oidcThis import can be made static, since the credential providers are dynamically imported.
Testing
We benchmarked
@aws-sdk/client-sts@v3.556.0
(latest version at the time of PR) getCallerIdentity operation for 100 counts before and after the change.Before
After
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.