chore: codegen to remove __type from Exception

[trivikr]

Issue #, if available:
Refs: smithy-lang/smithy-typescript#112

Description of changes:
codegen to remove __type from Exception

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[aws-sdk-js-automation]

AWS CodeBuild CI Report

• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[trivikr]

CI failure:

$ tsc
lerna ERR! yarn run pretest exited 2 in '@aws-sdk/client-apigatewaymanagementapi'
lerna ERR! yarn run pretest stdout:
$ tsc
protocols/Aws_restJson1_1.ts(326,9): error TS2741: Property '__type' is missing in type '{ name: "ForbiddenException"; $fault: "client"; $metadata: __ResponseMetadata; }' but required in type 'ForbiddenException'.
protocols/Aws_restJson1_1.ts(338,9): error TS2741: Property '__type' is missing in type '{ name: "GoneException"; $fault: "client"; $metadata: __ResponseMetadata; }' but required in type 'GoneException'.
protocols/Aws_restJson1_1.ts(350,9): error TS2741: Property '__type' is missing in type '{ name: "LimitExceededException"; $fault: "client"; $metadata: __ResponseMetadata; }' but required in type 'LimitExceededException'.
protocols/Aws_restJson1_1.ts(362,9): error TS2741: Property '__type' is missing in type '{ name: "PayloadTooLargeException"; $fault: "client"; $metadata: __ResponseMetadata; Message: undefined; }' but required in type 'PayloadTooLargeException'.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[trivikr]

This fails as __type is required in SmithyException interface

aws-sdk-js-v3/packages/smithy-client/src/exception.ts

Lines 6 to 9 in 6c3e098

	/**
	* The shape ID name of the exception.
	*/
	readonly __type: string;

[trivikr]

__type is also parsed while deserialization

aws-sdk-js-v3/clients/client-acm/protocols/Aws_json1_1.ts

Lines 413 to 415 in 6c3e098

	const errorTypeParts: String = parsedOutput.body["__type"].split("#");
	errorCode =
	errorTypeParts[1] === undefined ? errorTypeParts[0] : errorTypeParts[1];

CodeGen:

aws-sdk-js-v3/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/JsonRpcProtocolGenerator.java

Lines 106 to 112 in 6c3e098

	@Override
	protected void writeErrorCodeParser(GenerationContext context) {
	TypeScriptWriter writer = context.getWriter();
	// parsedOutput is in scope because HttpRpcProtocolGenerator.isErrorCodeInBody is true
	writer.write("const errorTypeParts: String = parsedOutput.body[\"__type\"].split('#');");
	writer.write("errorCode = (errorTypeParts[1] === undefined) ? errorTypeParts[0] : errorTypeParts[1];");
	}

[aws-sdk-js-automation]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (smithy-codegen@2b64381). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             smithy-codegen     #827   +/-   ##
=================================================
  Coverage                  ?   92.38%           
=================================================
  Files                     ?      147           
  Lines                     ?     2915           
  Branches                  ?      509           
=================================================
  Hits                      ?     2693           
  Misses                    ?      222           
  Partials                  ?        0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b64381...62f94f5. Read the comment docs.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.