fix: add smithy-kotlin to our bom and re-export to version catalog #1082
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view.
|
| } | ||
| } | ||
|
|
||
| val ignoredSmithyKotlin = setOf( |
There was a problem hiding this comment.
Question: Is it worth ignoring based on patterns like "contains test" or "contains codegen"? It's less explicit but maybe more likely to prevent the accidental inclusion of some new module...
There was a problem hiding this comment.
Yeah I was thinking the same but at the end of the day a BOM isn't including those dependencies just setting the versions to use and so even if it were included customers aren't likely depending on test deps unless they manually added them (unlikely). I can go either way though I just didn't want to inadvertently ignore something we actually want.
There was a problem hiding this comment.
I like the pattern-based approach more personally. I think it's better to accidentally omit something and add it later than to accidentally include something and remove it later.
There was a problem hiding this comment.
I could go either way but this explicit list seems fine given the low potential for impact
aajtodd
added
the
no-changelog
| } | ||
| } | ||
|
|
||
| val ignoredSmithyKotlin = setOf( |
There was a problem hiding this comment.
I could go either way but this explicit list seems fine given the low potential for impact
Issue #
n/a
Description of changes
#1072 added a BOM and version catalog artifact. This PR adds
smithy-kotlinto our BOM and re-exportssmithy-kotlinruntime from theaws-sdk-kotlinversion catalog for convenience.e.g.
dependencies { implementation(awsSdk.runtime.smithy.kotlin.http.client.engine.crt) implementation(awsSdk.services.s3) }Alternatives
smithy-kotlinalso publishes a version catalog. Originally I had wanted to get rid of a redeclaring these in the SDKlibs.versions.tomland just use that artifact directly for both theaws-runtimebuild files and in the BOM/version catalog from the SDK. Unfortunately version catalogs can only be created fromsettings.gradle.kts(withlibs.versions.tomlbeing created implicitly by convention). This doesn't play well with composite builds (you can't use the version catalog from an include build ofsmithy-kotlin).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.