feat: add support for detecting custom metadata in sys props and env vars #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view: __generated-main...__generated-feat-custom-metadata-from-env |
aajtodd
approved these changes
May 11, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-feat-custom-metadata-from-env |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Closes #575
Description of changes
Adds support for parsing custom metadata from system properties and environment variables.
System properties starting with
aws.customMetadata.will be parsed for key/value pairs. The keys are taken from the part of the system property name afteraws.customMetadata.For example, a system property ofaws.customMetadata.fooset tobarwill yield the custom metadatamd/foo/bar.Environment variables starting with
AWS_CUSTOM_METADATA_will be parsed for key/value pairs. The keys are take from the part of the env var name afterAWS_CUSTOM_METADATA_. For example, an environment variable ofAWS_CUSTOM_METADATA_fooset tobarwill yield the custom metadatamd/foo/bar.Companion PR: smithy-kotlin#638
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.