fix: correct the reporting of the service check build CI job #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
added
the
no-changelog
|
Kudos, SonarCloud Quality Gate passed!
|
|
Now seeing correct output from the polling loop: |
lauzadis
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
The service check build CI job occasionally fails when checking the status of the CodeBuild job too rapidly after starting it. This change moves the 10 second sleep to the start of the polling loop to ensure that the CodeBuild job is fully initialized before the first polling check.
This change also removes filtering on job identifiers starting with
JOB. Batch identifiers no longer begin withJOBbut are either a service name (e.g.,SAGEMAKER) or a numbered batch (e.g.,BATCH13). This led to finding zero jobs in every polling check, yielding the following output line:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.