Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide AWS{3,4}Signer that takes a HttpRequestMessage #397

Closed
paddie opened this issue Jun 24, 2016 · 8 comments
Closed

Provide AWS{3,4}Signer that takes a HttpRequestMessage #397

paddie opened this issue Jun 24, 2016 · 8 comments
Assignees
Labels
feature-request A feature should be added or improved. guidance Question that needs advice or information.

Comments

@paddie
Copy link

paddie commented Jun 24, 2016

Or is there some example of how to convert a HttpRequestMessage to an IRequest that the current AWS4Signer uses.

We're calling api-gateway using IAM authorization which requires the execute-api service, and that requires the AWS4Signature that uses HMAC-256. It would be really nice to have some maintained utility that enables one to sign a generic HttpRequestMessage.

I've copied this gist for now, but I am seeing some discrepancies between what is in the aws-sdk-net AWS4Signer.

Is there a better way than the one I am using?

@normj normj added feature-request A feature should be added or improved. Question labels Jun 24, 2016
@normj
Copy link
Member

normj commented Jun 24, 2016

We don't have a better approach now but making a signing code more accessible is something we want to do for these API Gateway cases.

@paddie
Copy link
Author

paddie commented Jun 24, 2016

Aye, that sounds good. I'm merging what is in the aws4signer and the gist
for now (since it is missing some steps), let me know if you want to look
at it. The signer will take only a HttpRequstMessage and add the Authorize
headers as your signer does.
On fre. 24. jun. 2016 at 18.12, Norm Johanson notifications@github.com
wrote:

We don't have a better approach now but making a signing code more
accessible is something we want to do for these API Gateway cases.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#397 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAaEQlo_pieUqMZNvdzK1Pyq48OWjN1Qks5qPAHdgaJpZM4I9jhD
.

@vellozzi vellozzi self-assigned this May 4, 2017
@vellozzi
Copy link
Contributor

vellozzi commented May 5, 2017

This has been added to our feature request list: https://github.com/aws/aws-sdk-net/blob/master/FEATURE_REQUESTS.md

@vellozzi vellozzi closed this as completed May 5, 2017
@jakejscott
Copy link

I'm using AWS Elastic Search Service and requests need to be signed.

There is a nuget package which has to implement the signing code but there's bugs in that library.

For example if you try to enable gzip compression it doesn't work and you get the error:

The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details.

https://github.com/bcuff/elasticsearch-net-aws

Is gzip compression compatible with v4 signing?

@niraj-bpsoftware
Copy link

Any update on when signer would be available as a utility in sdk?

@diehlaws diehlaws added guidance Question that needs advice or information. and removed Question labels Jan 3, 2019
@NeilBostrom
Copy link

NeilBostrom commented May 30, 2019

Just leaving a +1 for having public API for signing HttpClient requests (or anything really) and not having to use internal namespaces for it. My use case is querying an AppSync GraphQL API protected by V4 signing.

@slikk66
Copy link

slikk66 commented Jul 23, 2020

Having the ability to sign requests for AWS services should be considered a high priority for a production AWS SDK!

We just ran into a big roadblock here because I decided to use signed API GATEWAY for a project and one of our backend systems is in .NET and well, oof :/

@epvanhouten
Copy link

The SDK not enabling authenticating IAM against API Gateways is currently being a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. guidance Question that needs advice or information.
Projects
None yet
Development

No branches or pull requests

9 participants