Revert background refresh of credentials during preempt expiry period #4023
+40
−327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrsongg
approved these changes
Oct 1, 2025
muhammad-othman
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert the changes introduced in #3541 as we've had (at least) three separate reports of invalid credentials being returned in V4 (#4020, #3962, and #3873).
This is not a straight revert since we've had other changes to the
RefreshingAWSCredentialsclass since, but its implementation now matches V3 (which customers have confirmed does not have this problem): https://github.com/aws/aws-sdk-net/blob/aws-sdk-net-v3.7/sdk/src/Core/Amazon.Runtime/Credentials/RefreshingAWSCredentials.csTesting
Dry-runs:
DRY_RUN-b03759cf-5446-4231-b083-991451b33236DRY_RUN-3f624708-07f3-4535-97d0-5cf0c38aa20aLicense