Skip to content

Replace s3fs dependency by builtin mechanisms. #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2020
Merged

Replace s3fs dependency by builtin mechanisms. #370

merged 3 commits into from
Aug 30, 2020

Conversation

igorborgest
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@igorborgest igorborgest added this to the 1.9.0 milestone Aug 30, 2020
@igorborgest igorborgest self-assigned this Aug 30, 2020
@igorborgest igorborgest merged commit fc89ef1 into dev Aug 30, 2020
@igorborgest igorborgest deleted the remove-s3fs-dependency branch August 30, 2020 20:38
@jesusch
Copy link

jesusch commented Nov 4, 2020

hi @igorborgest

thanks for maintaining this project!
May you explain why s3fs was dropped?

Cheers
B

@igorborgest
Copy link
Contributor Author

Hi @jesusch , thanks for reaching out.

Starting from version 5.0.0 s3fs depends of aiobotocore to use async requests. For Wrangler we've chose to keep relying on boto3/botocore directly (officially supported by AWS) with a multithreading approach for concurrent requests.

@igorborgest igorborgest mentioned this pull request Nov 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@igorborgest igorborgest

Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@igorborgest @jesusch