Introduce DBSnapshotAvailable and DBSnapshotDeleted waiters for RDS DBSnapshot #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kstich
suggested changes
Sep 11, 2017
| "argument": "DBSnapshots[].Status" | ||
| }, | ||
| { | ||
| "expected": "DBInstanceNotFound", |
There was a problem hiding this comment.
This should be 'DBSnapshotNotFound', as specified here. The waiters-2.json.php compile will also need to be redone.
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
=========================================
Coverage 91.88% 91.88%
Complexity 2466 2466
=========================================
Files 142 142
Lines 7529 7529
=========================================
Hits 6918 6918
Misses 611 611Continue to review full report at Codecov.
|
rquadling
force-pushed
the
DBSnapshotWaiters
branch
2 times, most recently
from
cdeeacf to
dabfbce
Compare
…BSnapshot Original json and compiled php
rquadling
force-pushed
the
DBSnapshotWaiters
branch
from
dabfbce to
8369de0
Compare
kstich
approved these changes
Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified json and compiled php.
Resolves #1368