Skip to content

Conversation

kstich
Copy link
Contributor

@kstich kstich commented Jan 12, 2018

Fixes a bug where 'DestinationRegion' was not being added to automatically generated 'PreSignedUrl' parameters for RDS operations (CopyDBSnapshot, CreateDBInstanceReadReplica, CopyDBClusterSnapshot, and CreateDBCluster.)

Fixes #1462

/cc @jeskew

@kstich kstich added bug This issue is a bug. ready-for-review labels Jan 12, 2018
@kstich kstich requested a review from jeskew January 12, 2018 00:32
@codecov-io
Copy link

codecov-io commented Jan 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@c7f3148). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1468   +/-   ##
=========================================
  Coverage          ?   92.37%           
  Complexity        ?     2538           
=========================================
  Files             ?      160           
  Lines             ?     6729           
  Branches          ?        0           
=========================================
  Hits              ?     6216           
  Misses            ?      513           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
src/Rds/RdsClient.php 100% <ø> (ø) 1 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f3148...eaf5f67. Read the comment docs.

@kstich kstich closed this Jan 17, 2018
@kstich kstich deleted the rds_presignedurl_fix branch January 17, 2018 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants