Update README.md to reflect importlib.metadata usage #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`importlib.metadata` was introduced in python 3.8 but our guidance says 3.7 and up will work
jirkafajfr
previously approved these changes
Oct 9, 2024
|
can you change the setup.py as well? https://github.com/aws/aws-secretsmanager-caching-python/blob/master/setup.py#L25 |
hannah-nguyen-ca
previously approved these changes
Oct 9, 2024
YuvalShAz
dismissed stale reviews from hannah-nguyen-ca and jirkafajfr
via
fb7d454
jirkafajfr
approved these changes
Oct 9, 2024
wlewis4321
approved these changes
Oct 10, 2024
hannah-nguyen-ca
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importlib.metadatawas introduced in python 3.8 but our guidance says 3.7 and up will workIssue #, if available: #53
Description of changes: Changed python versions in README
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.