fix: InjectSecretString clobbering self arg in class methods (#24)
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmarty
requested changes
Apr 10, 2025
simonmarty
requested changes
Apr 15, 2025
simonmarty
previously approved these changes
Apr 28, 2025
vedant-jaiswal
previously approved these changes
Apr 28, 2025
ThirdEyeSqueegee
dismissed stale reviews from vedant-jaiswal and simonmarty
via
9a52b9b
vedant-jaiswal
approved these changes
Apr 28, 2025
simonmarty
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#24
Description of changes:
InjectSecretStringfrom clobbering theselfarg in class methods by injecting secrets as the second argument if the decorated function is a class methodBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.