-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dal/support for instance profiles #525
Merged
rbbarad
merged 19 commits into
aws:master
from
consilica:dal/support-for-instance-profiles
Jul 31, 2023
Merged
Dal/support for instance profiles #525
rbbarad
merged 19 commits into
aws:master
from
consilica:dal/support-for-instance-profiles
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ica/aws-toolkit-azure-devops into dal/support-for-instance-profiles
awschristou
reviewed
Jun 30, 2023
@daniel-lohausen-consilica Apologies about the delay, but things are looking good on my end after some manual testing! Thanks for the contribution! |
rbbarad
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asume a role without the need to provide ACCESS KEY ID/SECRET KEY
Description
One can now create a service connection without ACCESS KEY ID/SECRET KEY, but only a role to assume.
** IMPORTANT - We used the package.json from the 1.13 release for testing, we were otherwise blocked by #522
Motivation
When using EC2 instance profiles or ECS roles, it is common that the instance/container running the agent is only allowed to assume a role , which than grants other permissions. This use-case was not covered previously
Related Issue(s), If Filed
#511
#424
Testing
Checklist
npm run newChange
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.