Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dal/support for instance profiles #525

Merged
merged 19 commits into from
Jul 31, 2023

Conversation

daniel-lohausen-consilica
Copy link
Contributor

Asume a role without the need to provide ACCESS KEY ID/SECRET KEY

Description

One can now create a service connection without ACCESS KEY ID/SECRET KEY, but only a role to assume.

** IMPORTANT - We used the package.json from the 1.13 release for testing, we were otherwise blocked by #522

Motivation

When using EC2 instance profiles or ECS roles, it is common that the instance/container running the agent is only allowed to assume a role , which than grants other permissions. This use-case was not covered previously

Related Issue(s), If Filed

#511
#424

Testing

  • Ran all automated tests
  • Manually tested in a test environment

Checklist

  • [x ] I have read the README document
  • [x ] I have read the CONTRIBUTING document
  • [x ] My code follows the code style of this project
  • I have added tests to cover my changes
  • x[ ] A short description of the change has been added to the changelog using the script npm run newChange

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@daniel-lohausen-consilica daniel-lohausen-consilica requested a review from a team as a code owner June 30, 2023 09:58
@rbbarad
Copy link
Contributor

rbbarad commented Jul 31, 2023

@daniel-lohausen-consilica Apologies about the delay, but things are looking good on my end after some manual testing! Thanks for the contribution!

@rbbarad rbbarad merged commit 87ae4e2 into aws:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants