Skip to content

telemetry: lift definitions out of aws-toolkit-vscode #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 8, 2022
Merged

telemetry: lift definitions out of aws-toolkit-vscode #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bce9bd2
telemetry: lift definitions out of aws-toolkit-vscode
justinmk3 Jun 3, 2022
a403865
fixup! telemetry: lift definitions out of aws-toolkit-vscode
justinmk3 Jun 3, 2022
f39b117
fixup! fixup! telemetry: lift definitions out of aws-toolkit-vscode
justinmk3 Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
{
"name": "lambdaArchitecture",
"allowedValues": ["x86_64", "arm64"],
"description": "The Lambda Architecture of the function"
"description": "Lambda architecture identifier"
},
{
"name": "serviceType",
Expand Down Expand Up @@ -379,7 +379,8 @@
{ "type": "runtime", "required": false },
{ "type": "httpMethod", "required": false },
{ "type": "result" },
{ "type": "debug" }
{ "type": "debug" },
{ "type": "lambdaArchitecture", "required": false }
]
},
{
Expand Down Expand Up @@ -959,7 +960,8 @@
{ "type": "version", "required": false },
{ "type": "lambdaPackageType" },
{ "type": "result" },
{ "type": "debug" }
{ "type": "debug" },
{ "type": "lambdaArchitecture", "required": false }
]
},
{
Expand Down Expand Up @@ -1047,7 +1049,8 @@
{ "type": "version", "required": false },
{ "type": "lambdaPackageType", "required": false },
{ "type": "reason", "required": false },
{ "type": "eventBridgeSchema", "required": false }
{ "type": "eventBridgeSchema", "required": false },
{ "type": "lambdaArchitecture", "required": false }
]
},
{
Expand Down
9 changes: 8 additions & 1 deletion telemetry/definitions/vscodeDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,14 @@
{
"name": "sam_attachDebugger",
"description": "Called after trying to attach a debugger to a local sam invoke",
"metadata": [{ "type": "result" }, { "type": "lambdaPackageType" }, { "type": "runtime" }, { "type": "attempts" }, { "type": "duration" }]
"metadata": [
{ "type": "result" },
{ "type": "lambdaPackageType" },
{ "type": "runtime" },
{ "type": "attempts" },
{ "type": "duration" },
{ "type": "lambdaArchitecture", "required": false }
]
},
{
"name": "sam_openConfigUi",
Expand Down