Skip to content

Conversation

abrooksv
Copy link
Contributor

Creates a custom S3 bucket editor to navigate an S3 bucket
Includes Bucket and Object detail pages
Includes a S3 VirtualFileSystem that can load files into IntelliJ

objectdetails
bucketdetails

@abrooksv abrooksv requested a review from zhangzhx July 25, 2017 22:39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does metadata encompass tags? what if metadata isn't modified but tags are?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it falls into the else branch and we just update tags...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya it is kinda gross. Docs say the only way to change metadata is to issue a copy request so we have to execute the copy. If tags also are changed we will put the new ones in the Copy request so it happens in one go.

If only tags get changed we can do an in place update using the SetObjectTaggingRequest API

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the Wrapper do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a Component in IntelliJ. Here is the code:
https://github.com/JetBrains/intellij-community/blob/master/platform/platform-api/src/com/intellij/ui/components/panels/Wrapper.java

Easy abstraction for a placeholder panel where we replace the contents and not worry about what was there before

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a bucket not a directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya it should be

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this get executed? This is a blocking call right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Tree calls it, which handles async loading in a pooled thread off the UI threads

Creates a custom S3 bucket editor to navigate an S3 bucket
Includes Bucket and Object detail pages
Includes a S3 VirtualFileSystem that can load files into IntelliJ
@kiiadi kiiadi merged commit bd910d5 into master Jan 31, 2018
@abrooksv abrooksv deleted the abrooksv-s3 branch February 15, 2018 23:42
Randall-Jiang pushed a commit to Randall-Jiang/aws-toolkit-jetbrains that referenced this pull request Jun 9, 2025
* fix: Add mcp: true in the aws Client capabilities when init LSP.

* fix: moving mcp config under q
manodnyab added a commit that referenced this pull request Jun 9, 2025
* add mcp msgs

* add mcp

* add summary

* use any for optvalue

* format code

* fix: Add mcp: true in the aws Client capabilities when init LSP. (#3)

* fix: Add mcp: true in the aws Client capabilities when init LSP.

* fix: moving mcp config under q

* pr comment

* delete not reqd changes

---------

Co-authored-by: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com>
Co-authored-by: aws-toolkit-automation <43144436+aws-toolkit-automation@users.noreply.github.com>
Co-authored-by: Manodnya Bhoite <manodnyb@amazon.com>
Co-authored-by: manodnyab <66754471+manodnyab@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants