-
Notifications
You must be signed in to change notification settings - Fork 273
Start a S3 bucket viewer #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does metadata encompass tags? what if metadata isn't modified but tags are?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it falls into the else branch and we just update tags...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya it is kinda gross. Docs say the only way to change metadata is to issue a copy request so we have to execute the copy. If tags also are changed we will put the new ones in the Copy request so it happens in one go.
If only tags get changed we can do an in place update using the SetObjectTaggingRequest API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the Wrapper
do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a Component in IntelliJ. Here is the code:
https://github.com/JetBrains/intellij-community/blob/master/platform/platform-api/src/com/intellij/ui/components/panels/Wrapper.java
Easy abstraction for a placeholder panel where we replace the contents and not worry about what was there before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a bucket not a directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya it should be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this get executed? This is a blocking call right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Tree calls it, which handles async loading in a pooled thread off the UI threads
Creates a custom S3 bucket editor to navigate an S3 bucket Includes Bucket and Object detail pages Includes a S3 VirtualFileSystem that can load files into IntelliJ
* fix: Add mcp: true in the aws Client capabilities when init LSP. * fix: moving mcp config under q
* add mcp msgs * add mcp * add summary * use any for optvalue * format code * fix: Add mcp: true in the aws Client capabilities when init LSP. (#3) * fix: Add mcp: true in the aws Client capabilities when init LSP. * fix: moving mcp config under q * pr comment * delete not reqd changes --------- Co-authored-by: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Co-authored-by: aws-toolkit-automation <43144436+aws-toolkit-automation@users.noreply.github.com> Co-authored-by: Manodnya Bhoite <manodnyb@amazon.com> Co-authored-by: manodnyab <66754471+manodnyab@users.noreply.github.com>
Creates a custom S3 bucket editor to navigate an S3 bucket
Includes Bucket and Object detail pages
Includes a S3 VirtualFileSystem that can load files into IntelliJ