Skip to content

config(amazonq): lower timeout for auto reviews #5280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2025
Merged

config(amazonq): lower timeout for auto reviews #5280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
230d4be
config(amazonq): lower timeout for auto reviews
ctlai95 Jan 17, 2025
35f96b7
Merge branch 'main' into express-scan-timeout
ctlai95 Jan 17, 2025
33a3964
Merge branch 'main' into express-scan-timeout
ctlai95 Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...toolkits/jetbrains/services/codewhisperer/codescan/sessionconfig/CodeScanSessionConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhisperer
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants.CodeAnalysisScope
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants.DEFAULT_CODE_SCAN_TIMEOUT_IN_SECONDS
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants.DEFAULT_PAYLOAD_LIMIT_IN_BYTES
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants.EXPRESS_SCAN_TIMEOUT_IN_SECONDS
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants.FILE_SCAN_PAYLOAD_SIZE_LIMIT_IN_BYTES
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants.FILE_SCAN_TIMEOUT_IN_SECONDS
import software.aws.toolkits.jetbrains.services.codewhisperer.util.isWithin
import software.aws.toolkits.resources.message
import software.aws.toolkits.telemetry.CodewhispererLanguage
Expand Down Expand Up @@ -68,9 +68,11 @@ class CodeScanSessionConfig(
/**
* Timeout for the overall job - "Run Security Scan".
*/
fun overallJobTimeoutInSeconds(): Long = when (scope) {
CodeAnalysisScope.FILE -> FILE_SCAN_TIMEOUT_IN_SECONDS
else -> DEFAULT_CODE_SCAN_TIMEOUT_IN_SECONDS
fun overallJobTimeoutInSeconds(): Long {
if (scope == CodeAnalysisScope.FILE && !initiatedByChat) {
return EXPRESS_SCAN_TIMEOUT_IN_SECONDS
}
return DEFAULT_CODE_SCAN_TIMEOUT_IN_SECONDS
}

fun getPayloadLimitInBytes(): Long = when (scope) {
Expand Down
2 changes: 1 addition & 1 deletion ...src/software/aws/toolkits/jetbrains/services/codewhisperer/util/CodeWhispererConstants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ object CodeWhispererConstants {
const val FILE_SCAN_INITIAL_POLLING_INTERVAL_IN_SECONDS: Long = 10
const val PROJECT_SCAN_INITIAL_POLLING_INTERVAL_IN_SECONDS: Long = 30
const val CODE_SCAN_CREATE_PAYLOAD_TIMEOUT_IN_SECONDS: Long = 10
const val FILE_SCAN_TIMEOUT_IN_SECONDS: Long = 60 * 10 // 10 minutes
const val EXPRESS_SCAN_TIMEOUT_IN_SECONDS: Long = 60
const val FILE_SCAN_PAYLOAD_SIZE_LIMIT_IN_BYTES: Long = 1024 * 200 // 200KB
const val AUTO_SCAN_DEBOUNCE_DELAY_IN_SECONDS: Long = 30
const val CODE_FIX_CREATE_PAYLOAD_TIMEOUT_IN_SECONDS: Long = 10
Expand Down
Loading