feat(sam): improved TypeScript support #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JadenSimon
reviewed
Jan 13, 2023
.changes/next-release/Feature-46a93a97-f979-4c7a-9a8d-f241a30987b6.json
Outdated
Show resolved
Hide resolved
| @@ -90,7 +96,7 @@ export async function makeInputTemplate( | |||
| .withRuntime(config.lambda!.runtime!) | |||
| .withCodeUri(pathutil.normalize(config.invokeTarget.projectRoot)) | |||
|
|
|||
| if (config.lambda?.environmentVariables) { | |||
| if (config.lambda?.environmentVariables && Object.entries(config.lambda?.environmentVariables).length) { | |||
|
/runintegrationtests .... |
JadenSimon
reviewed
Jan 13, 2023
| // Adapted from: https://github.com/aws/aws-toolkit-jetbrains/blob/911c54252d6a4271ee6cacf0ea1023506c4b504a/jetbrains-ultimate/src/software/aws/toolkits/jetbrains/services/lambda/nodejs/NodeJsLambdaBuilder.kt#L60 | ||
| const defaultTsconfig = { | ||
| compilerOptions: { | ||
| const tsConfigPath = path.join(config.codeRoot, tsConfigFile) |
There was a problem hiding this comment.
It'd be really nice if we could write this to the build directory if possible. Maybe we can use extends instead of directly merging config files?
JadenSimon
approved these changes
Jan 24, 2023
JadenSimon
changed the title
This was referenced Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TypeScript debugger has a race condition that breaks debugging much of the time. Hard-coded tsconfig also is used which breaks anything more than a very basic typescript lambda.
Solution
Updated toolkit to generate tsconfig that attempts to match project tsconfig as close as possible, code is compiled into a ts build directory, sam deploys from there on an updated handler path (pointing to build dir). This eliminates the debugger race condition, and much more closely resembles a standard project build eliminating all of our errors. It also matches jetbrains approach here.
Code updated:
Tested with unit tests, and with several typescript projects including large and small lambdas. New code lines are covered with code coverage.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.