Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cloudwatch-metrics: Add container insights with enhanced observability #1041

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

0xtvignoli
Copy link
Contributor

@0xtvignoli 0xtvignoli commented Dec 15, 2023

Pull Request for New Feature Implementation

Feature Description

On November 6, 2023, a new version of Container Insights was released. This version supports enhanced observability for Amazon EKS clusters running on Amazon EC2 and can collect more detailed metrics from these clusters.

Description of changes

  • Added a new boolean parameter to the configmap template.
  • Updated the chart to incorporate the latest available image.
  • Utilized semantic versioning for updating the chart tag.
  • Modified the README to document the introduced changes.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts).
  • Incremented the chart version in Chart.yaml for the modified chart(s).
  • Manually tested. See dump template file attached.
  • Make sure the title of the PR is a good description that can go into the release notes.

Testing

Here dump of the template chart
debug.zip

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@texano00
Copy link

@tvignoli exactly the same need there, thanks for the contribution! 🙏

@ricbra
Copy link

ricbra commented Jan 3, 2024

+1 also looking for this!

@tvignoli One question: if I compare the Container Insights with enhanced observability PR (can be found here aws-samples/amazon-cloudwatch-container-insights#150) on the AWS examples repository they also added some additional permission to the ClusterRole :

  - apiGroups: ["apps"]
   # old
    resources: ["replicasets", "daemonsets", "deployments"]
    # new
    resources: ["replicasets", "daemonsets", "deployments", "statefulsets"]

@0xtvignoli
Copy link
Contributor Author

@ricbra Thanks for the note, I think its a very good suggestion
I will try the change tomorrow, in case it brings added value I will update the PR

@0xtvignoli
Copy link
Contributor Author

PR updated with ClusterRole permission extended.
I share the logs recorded by the pod
image

@ivan-sukhomlyn
Copy link

@tvignoli thanks!
It will resolve the #1055 as well.

@0xtvignoli
Copy link
Contributor Author

Any chance this PR can be reviewed? Thanks!

@ivan-sukhomlyn
Copy link

@bwagner5 @kishorj @fawadkhaliq @jaypipes can you please take a look at this PR? 🙏 Thanks!

@fawadkhaliq
Copy link

@bwagner5 @kishorj @fawadkhaliq @jaypipes can you please take a look at this PR? 🙏 Thanks!

Tagging @jayanthvn @M00nF1sh to help find the owner.

Copy link
Contributor

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks for the contribution, the change looks good to me

@M00nF1sh M00nF1sh merged commit 699a124 into aws:master Feb 7, 2024
@kangadrewie
Copy link
Contributor

This is awesome. When will v0.0.10 be available in stable? Can I use this now?

@kangadrewie
Copy link
Contributor

@M00nF1sh is there a schedule for releases? Any idea when this will be available?

@M00nF1sh
Copy link
Contributor

M00nF1sh commented Feb 9, 2024

@kangadrewie just cut a release, the charts shall be available now

@kangadrewie
Copy link
Contributor

kangadrewie commented Feb 10, 2024

@tvignoli should this work out the box? Have deployed v0.0.10 to my EKS cluster with enhanced obs turned on. I'm not seeing any of the enhanced metrics coming into CW.

Am seeing the agents OTEL awsemf exporter has enhanced_container_insights: false.

Yet my configmap has it enabled.

apiVersion: v1
data:
  cwagentconfig.json: |
    {
      "logs": {
        "metrics_collected": {
          "kubernetes": {
            "cluster_name": "<cluster-name>",
            "enhanced_container_insights": "true",
            "metrics_collection_interval": 60
          }
        },
        "force_flush_interval": 5
      }
    }
kind: ConfigMap

Any prerequisites for this to work?

@kangadrewie
Copy link
Contributor

Issue found, PR to fix - #1062

@0xtvignoli
Copy link
Contributor Author

Make sense, dumb mistake from my side.
Thanks @kangadrewie for prompt fix 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants