-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-cloudwatch-metrics: Add container insights with enhanced observability #1041
Conversation
@tvignoli exactly the same need there, thanks for the contribution! 🙏 |
+1 also looking for this! @tvignoli One question: if I compare the Container Insights with enhanced observability PR (can be found here aws-samples/amazon-cloudwatch-container-insights#150) on the AWS examples repository they also added some additional permission to the - apiGroups: ["apps"]
# old
resources: ["replicasets", "daemonsets", "deployments"]
# new
resources: ["replicasets", "daemonsets", "deployments", "statefulsets"] |
@ricbra Thanks for the note, I think its a very good suggestion |
@tvignoli thanks! |
Any chance this PR can be reviewed? Thanks! |
@bwagner5 @kishorj @fawadkhaliq @jaypipes can you please take a look at this PR? 🙏 Thanks! |
Tagging @jayanthvn @M00nF1sh to help find the owner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks for the contribution, the change looks good to me
This is awesome. When will |
@M00nF1sh is there a schedule for releases? Any idea when this will be available? |
@kangadrewie just cut a release, the charts shall be available now |
@tvignoli should this work out the box? Have deployed Am seeing the agents OTEL Yet my configmap has it enabled.
Any prerequisites for this to work? |
Issue found, PR to fix - #1062 |
Make sense, dumb mistake from my side. |
Pull Request for New Feature Implementation
Feature Description
On November 6, 2023, a new version of Container Insights was released. This version supports enhanced observability for Amazon EKS clusters running on Amazon EC2 and can collect more detailed metrics from these clusters.
Description of changes
Checklist
README.md
for modified charts).version
inChart.yaml
for the modified chart(s).Testing
Here dump of the template chart
debug.zip
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.