Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Updated notebook rendering as suggested in issue 316 #320

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

polaschwoebel
Copy link
Contributor

Issue #316

Some users experience issues rendering the radar plot in the model-comparison.ipynb notebook. This PR implements the requested fix.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@xiaoyi-cheng
Copy link
Contributor

Can you please remove the example_results folder? Thanks!

@polaschwoebel
Copy link
Contributor Author

Can you please remove the example_results folder? Thanks!

Why? The idea behind this notebook is to show how to plot results, and by providing example results the user can do just that (without running the evaluations first). Note that the folder is also present in the current mainline. Please explain.

@polaschwoebel polaschwoebel merged commit 346413c into aws:main Aug 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants