Improve %seed error handling #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bechbd
approved these changes
Jan 18, 2022
michaelnchin
added a commit
that referenced
this pull request
Apr 23, 2022
* Add error handling options for seed * Refactoring Co-authored-by: Michael Chin <chnmch@amazon.com>
michaelnchin
added a commit
that referenced
this pull request
Apr 23, 2022
Modify datasets test Improve widget option switching, add unit tests Remove debug Support Cypher query datasets, use separate --language and --model options depending on source type Update seed command documentation Update languages for clarity Remove lowercasing of file path, status statements Improve %seed error handling (#246) * Add error handling options for seed * Refactoring Co-authored-by: Michael Chin <chnmch@amazon.com> Modify Cypher error handling Revise notebooks for seed changes Fix for test failure Manually verify that queries are insert type Remove hard-coded prefix checks Add file browser UI More file selection changes Disable language widget on submit Support individual seed file paths Usability improvements and documentation Remove --source-type option, more refactoring Update sample notebooks and README Add single file load unit tests remove remaining references to source_type Add option for Gremlin full-file queries Modify full-file query option to also support Cypher More graceful handling for invalid args Preserve widget states when switching between options Fix switching source back to custom with no current language value Fix query progress displaying incorrectly
michaelnchin
added a commit
that referenced
this pull request
May 11, 2023
* Support using %seed with local file path Modify datasets test Improve widget option switching, add unit tests Remove debug Support Cypher query datasets, use separate --language and --model options depending on source type Update seed command documentation Update languages for clarity Remove lowercasing of file path, status statements Improve %seed error handling (#246) * Add error handling options for seed * Refactoring Co-authored-by: Michael Chin <chnmch@amazon.com> Modify Cypher error handling Revise notebooks for seed changes Fix for test failure Manually verify that queries are insert type Remove hard-coded prefix checks Add file browser UI More file selection changes Disable language widget on submit Support individual seed file paths Usability improvements and documentation Remove --source-type option, more refactoring Update sample notebooks and README Add single file load unit tests remove remaining references to source_type Add option for Gremlin full-file queries Modify full-file query option to also support Cypher More graceful handling for invalid args Preserve widget states when switching between options Fix switching source back to custom with no current language value Fix query progress displaying incorrectly * missing import * Update Changelog * Improve logic for choosing PG language endpoint on custom load, other misc fixes * linter fix * fix changelog entry --------- Co-authored-by: Michael Chin <chnmch@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #69
Description of changes:
%seednow ignores any blank lines in seed files.--ignore-errorsoption to%seed. If specified, errors thrown by individual query lines will not terminate the load.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.