Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kernel): json deserialization fails on null value #4000

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Mar 13, 2023

The JSON serialization class is a quasi-synonym for Map<string, any>, except it is meant to accept any valid JSON object, including one with null values. The serializer was however interpreting these as Map<string, JSON> when wired as a $jsii.map envelope, and this serialization class does NOT allow for null values.

Addresses the "easy" part of aws/aws-cdk#14639 (more complicated is that it would need to preserve null across the process boundary, which is currently not possible).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The JSON serialization class is a quasi-synonym for `Map<string, any>`,
except it is meant to accept any valid JSON object, including one with
`null` values. The serializer was however interpreting these as
`Map<string, JSON>` when wired as a `$jsii.map` envelope, and this
serialization class does NOT allow for null values.
@RomainMuller RomainMuller self-assigned this Mar 13, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Mar 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2023

Merging (with squash)...

@mergify mergify bot merged commit 884b0ff into main Mar 13, 2023
@mergify mergify bot deleted the rmuller/fix-json-deserialization branch March 13, 2023 14:45
@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2023

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants