Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop cloudwatch agent #6269

Merged
merged 1 commit into from
May 25, 2024
Merged

ci: drop cloudwatch agent #6269

merged 1 commit into from
May 25, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented May 25, 2024

Fixes #N/A

Description
Remove the cloudwatch agent used for log forwarding to unblock testing with EKS 1.30. The cloud watch agent is currently unsupported on EKS 1.30 and blocks cluster creation in our E2E suite.

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner May 25, 2024 00:02
@jmdeal jmdeal requested a review from ljosyula May 25, 2024 00:02
Copy link

netlify bot commented May 25, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit db88508
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66512d2f1694cd0008333db6

@jmdeal jmdeal force-pushed the ci/drop-cloudwatch-agent branch 2 times, most recently from 04832fc to b3ceee3 Compare May 25, 2024 00:06
@coveralls
Copy link

coveralls commented May 25, 2024

Pull Request Test Coverage Report for Build 9231320177

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.55%

Totals Coverage Status
Change from base Build 9230481042: 0.0%
Covered Lines: 5549
Relevant Lines: 6722

💛 - Coveralls

Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-db8850863b6b7845aac61b91af618fae72d2316c.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-db8850863b6b7845aac61b91af618fae72d2316c" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit b3076dc into aws:main May 25, 2024
20 of 30 checks passed
@jmdeal jmdeal mentioned this pull request May 25, 2024
3 tasks
@jmdeal jmdeal deleted the ci/drop-cloudwatch-agent branch August 14, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants