Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add status conditions on nodeClass #6455

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description

How was this change tested?
This PR adds status conditions to EC2nodeClass.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner July 6, 2024 00:48
@jigisha620 jigisha620 requested a review from bwagner5 July 6, 2024 00:48
Copy link

netlify bot commented Jul 6, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 081f5f5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/668c6c80c3528600083aacfe

@coveralls
Copy link

coveralls commented Jul 6, 2024

Pull Request Test Coverage Report for Build 9815229884

Details

  • 12 of 23 (52.17%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 78.932%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclass/status/ami.go 1 2 50.0%
pkg/controllers/nodeclass/status/instanceprofile.go 1 2 50.0%
pkg/apis/v1/ec2nodeclass_status.go 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/apis/v1/ec2nodeclass_status.go 1 0.0%
Totals Coverage Status
Change from base Build 9786416051: 0.2%
Covered Lines: 5957
Relevant Lines: 7547

💛 - Coveralls

@ellistarn
Copy link
Contributor

Nice work! Can you confirm that all of this is happening out-of-band from the launch path? My understanding is that this is a separate "readiness" controller, and once it's marked as ready, it can be used by the provisioning/consolidation control loops.

@coveralls
Copy link

coveralls commented Jul 8, 2024

Pull Request Test Coverage Report for Build 9847987399

Details

  • 12 of 22 (54.55%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 79.049%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclass/status/ami.go 1 2 50.0%
pkg/apis/v1/ec2nodeclass_status.go 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 93.33%
pkg/apis/v1/ec2nodeclass_status.go 1 0.0%
Totals Coverage Status
Change from base Build 9845832720: 0.2%
Covered Lines: 5969
Relevant Lines: 7551

💛 - Coveralls

@jigisha620
Copy link
Contributor Author

Nice work! Can you confirm that all of this is happening out-of-band from the launch path? My understanding is that this is a separate "readiness" controller, and once it's marked as ready, it can be used by the provisioning/consolidation control loops.

Yes, this will happen separately from the launch path. NodeClass readiness will be propagated to nodePool which will make nodePool not ready if nodeClass is not ready and we will skip such nodePools when making scheduling decisions.

@jigisha620 jigisha620 merged commit eb019db into aws:main Jul 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants