You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice work! Can you confirm that all of this is happening out-of-band from the launch path? My understanding is that this is a separate "readiness" controller, and once it's marked as ready, it can be used by the provisioning/consolidation control loops.
Nice work! Can you confirm that all of this is happening out-of-band from the launch path? My understanding is that this is a separate "readiness" controller, and once it's marked as ready, it can be used by the provisioning/consolidation control loops.
Yes, this will happen separately from the launch path. NodeClass readiness will be propagated to nodePool which will make nodePool not ready if nodeClass is not ready and we will skip such nodePools when making scheduling decisions.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
How was this change tested?
This PR adds status conditions to EC2nodeClass.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.