Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to use karpv1 taint #6558

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix: update to use karpv1 taint #6558

merged 2 commits into from
Jul 19, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Jul 19, 2024

Fixes #N/A

Description
Use the taint defined in kubernetes-sigs/karpenter

How was this change tested?
make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner July 19, 2024 22:51
@rschalo rschalo requested a review from jmdeal July 19, 2024 22:51
Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 5f2e0f0
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/669aee3b81f77500083aa180
😎 Deploy Preview https://deploy-preview-6558--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rschalo rschalo enabled auto-merge (squash) July 19, 2024 22:52
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10015298572

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 79.134%

Totals Coverage Status
Change from base Build 10014578218: 0.01%
Covered Lines: 5943
Relevant Lines: 7510

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit 0642ce2 into aws:main Jul 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants