Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update counter metrics to have suffix _total #6577

Merged
merged 1 commit into from
Jul 24, 2024
Merged

docs: Update counter metrics to have suffix _total #6577

merged 1 commit into from
Jul 24, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
This PR updates docs for counter metrics to have suffix _total.

How was this change tested?
NA

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner July 23, 2024 23:35
@jigisha620 jigisha620 requested a review from njtran July 23, 2024 23:35
@netlify Netlify
Copy link

netlify bot commented Jul 23, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit ca1b313
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66a03e327cdb570009e2f56e
😎 Deploy Preview https://deploy-preview-6577--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10067879552

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 79.104%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
Totals Coverage Status
Change from base Build 10066443911: -0.01%
Covered Lines: 5936
Relevant Lines: 7504
💛 - Coveralls

@engedaam
Copy link
Contributor

Do we need to bump upstream version?

engedaam
engedaam approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit 2f25e3a into aws:main Jul 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

@njtran njtran Awaiting requested review from njtran njtran is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jigisha620 @coveralls @engedaam