Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change metrics port #6578

Merged
merged 6 commits into from
Jul 25, 2024
Merged

feat: Change metrics port #6578

merged 6 commits into from
Jul 25, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Jul 24, 2024 •
edited
Loading

Fixes #N/A

Description
This changes the metrics port in anticipation of v1.

How was this change tested?
make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify Netlify
Copy link

netlify bot commented Jul 24, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit a0bc00c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66a2b6c786adfd00084768c2

@rschalo rschalo changed the title feat: Change webhook port feat: Change metrics port Jul 24, 2024
@coveralls
Copy link

coveralls commented Jul 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10101104501

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.132%
Totals Coverage Status
Change from base Build 10085505927: 0.0%
Covered Lines: 5927
Relevant Lines: 7490
💛 - Coveralls

@rschalo rschalo marked this pull request as ready for review July 24, 2024 06:11
@rschalo rschalo requested a review from a team as a code owner July 24, 2024 06:11
@rschalo rschalo requested a review from bwagner5 July 24, 2024 06:11
@rschalo rschalo enabled auto-merge (squash) July 24, 2024 21:55
jonathan-innis
jonathan-innis approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit 129d4ac into aws:main Jul 25, 2024
17 checks passed
@rschalo rschalo deleted the change-webhook-port branch July 25, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rschalo @coveralls @jonathan-innis