Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return to DoNotSchedule #6584

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: return to DoNotSchedule #6584

merged 1 commit into from
Jul 24, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Jul 24, 2024

Fixes #N/A

Description
Return to DoNotSchedule

How was this change tested?
make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner July 24, 2024 21:50
@rschalo rschalo requested a review from jmdeal July 24, 2024 21:50
@netlify Netlify
Copy link

netlify bot commented Jul 24, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 2c1b7d6
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66a1773c10a3580008971e5b

njtran
njtran approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rschalo rschalo enabled auto-merge (squash) July 24, 2024 21:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10084524488

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 79.104%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
Totals Coverage Status
Change from base Build 10084456981: -0.01%
Covered Lines: 5936
Relevant Lines: 7504
💛 - Coveralls

@rschalo rschalo merged commit fdd51b4 into aws:main Jul 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rschalo @coveralls @njtran