Support PG18

[diogotcorreia]

Description

Can't build on PG18 BETA 2:

src/tleextension.c:1185:29: error: too many arguments to function call, expected 8, have 9
 1179 |                                 qdesc = CreateQueryDesc(stmt,
      |                                         ~~~~~~~~~~~~~~~
 1180 | #if PG_VERSION_NUM >= 180000
 1181 |                                                                                 NULL,
 1182 | #endif
 1183 |                                                                                 sql,
 1184 |                                                                                 GetActiveSnapshot(), NULL,
 1185 |                                                                                 dest, NULL, NULL, 0);
      |                                                                                                   ^
/nix/store/zhqcfvwnmqrjjpvyggfagqynchh2b44c-postgresql-18beta2-dev/include/server/executor/execdesc.h:59:19: note: 'CreateQueryDesc' declared here
   59 | extern QueryDesc *CreateQueryDesc(PlannedStmt *plannedstmt,
      |                   ^               ~~~~~~~~~~~~~~~~~~~~~~~~~
   60 |                                                                   const char *sourceText,
      |                                                                   ~~~~~~~~~~~~~~~~~~~~~~~
   61 |                                                                   Snapshot snapshot,
      |                                                                   ~~~~~~~~~~~~~~~~~~
   62 |                                                                   Snapshot crosscheck_snapshot,
      |                                                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   63 |                                                                   DestReceiver *dest,
      |                                                                   ~~~~~~~~~~~~~~~~~~~
   64 |                                                                   ParamListInfo params,
      |                                                                   ~~~~~~~~~~~~~~~~~~~~~
   65 |                                                                   QueryEnvironment *queryEnv,
      |                                                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
   66 |                                                                   int instrument_options);
      |                                                                   ~~~~~~~~~~~~~~~~~~~~~~
3 warnings and 1 error generated.
make: *** [<builtin>: src/tleextension.o] Error 1

Note: using this as a tracking issue for this package in nixpkgs.

Analysis

The #289 PR has to be reversed, since the relevant commit upstream has been reverted as well: postgres/postgres@1722d5e#diff-c6b1a39ad0c6141b7f271fd722597f04256bfd5c7b2acb86c03e7d20e6a706a6

[devrimgunduz]

Fails to build against PostgreSQL 18.0:

/usr/bin/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -Wno-format-truncation -O2  -I./include -I. -I./ -I/usr/pgsql-18/include/server -I/usr/pgsql-18/include/internal -D_GNU_SOURCE  -I/usr/include -I/usr/include/libxml2 -DWITH_GZFILEOP    -flto=thin -emit-llvm -c -o src/guc-file.bc src/guc-file.c
src/tleextension.c:1185:29: error: too many arguments to function call, expected 8, have 9
 1179 |                                 qdesc = CreateQueryDesc(stmt,
      |                                         ~~~~~~~~~~~~~~~
 1180 | #if PG_VERSION_NUM >= 180000
 1181 |                                                                                 NULL,
 1182 | #endif
 1183 |                                                                                 sql,
 1184 |                                                                                 GetActiveSnapshot(), NULL,
 1185 |                                                                                 dest, NULL, NULL, 0);
      |                                                                                                   ^
/usr/pgsql-18/include/server/executor/execdesc.h:59:19: note: 'CreateQueryDesc' declared here
   59 | extern QueryDesc *CreateQueryDesc(PlannedStmt *plannedstmt,
      |                   ^               ~~~~~~~~~~~~~~~~~~~~~~~~~
   60 |                                                                   const char *sourceText,
      |                                                                   ~~~~~~~~~~~~~~~~~~~~~~~
   61 |                                                                   Snapshot snapshot,
      |                                                                   ~~~~~~~~~~~~~~~~~~
   62 |                                                                   Snapshot crosscheck_snapshot,
      |                                                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   63 |                                                                   DestReceiver *dest,
      |                                                                   ~~~~~~~~~~~~~~~~~~~
   64 |                                                                   ParamListInfo params,
      |                                                                   ~~~~~~~~~~~~~~~~~~~~~
   65 |                                                                   QueryEnvironment *queryEnv,
      |                                                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
   66 |                                                                   int instrument_options);
      |                                                                   ~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [/usr/pgsql-18/lib/pgxs/src/makefiles/../../src/Makefile.global:1104: src/tleextension.bc] Error 1
make[1]: *** Waiting for unfinished jobs....
src/tleextension.c:138:17: warning: no previous declaration for ‘cb_registered’ [-Wmissing-variable-declarations]
  138 | bool            cb_registered = false;
      |                 ^~~~~~~~~~~~~
src/tleextension.c:141:17: warning: no previous declaration for ‘tleart’ [-Wmissing-variable-declarations]
  141 | bool            tleart = false;
      |                 ^~~~~~
src/tleextension.c:157:17: warning: no previous declaration for ‘tleext’ [-Wmissing-variable-declarations]
  157 | bool            tleext = false;
      |                 ^~~~~~
src/tleextension.c: In function ‘execute_sql_string’:
src/tleextension.c:1183:81: error: passing argument 3 of ‘CreateQueryDesc’ from incompatible pointer type [-Wincompatible-pointer-types]
 1183 |                                                                                 sql,
      |                                                                                 ^~~
      |                                                                                 |
      |                                                                                 const char *
In file included from /usr/pgsql-18/include/server/utils/portal.h:50,
                 from /usr/pgsql-18/include/server/executor/spi.h:19,
                 from src/tleextension.c:67:
/usr/pgsql-18/include/server/executor/execdesc.h:61:76: note: expected ‘Snapshot’ {aka ‘struct SnapshotData *’} but argument is of type ‘const char *’
   61 |                                                                   Snapshot snapshot,
      |                                                                   ~~~~~~~~~^~~~~~~~
In file included from /usr/pgsql-18/include/server/access/genam.h:24,
                 from src/tleextension.c:32:
/usr/pgsql-18/include/server/utils/snapshot.h:117:30: note: ‘Snapshot’ declared here
  117 | typedef struct SnapshotData *Snapshot;
      |                              ^~~~~~~~
src/tleextension.c:1185:81: error: passing argument 6 of ‘CreateQueryDesc’ from incompatible pointer type [-Wincompatible-pointer-types]
 1185 |                                                                                 dest, NULL, NULL, 0);
      |                                                                                 ^~~~
      |                                                                                 |
      |                                                                                 DestReceiver * {aka struct _DestReceiver *}
/usr/pgsql-18/include/server/executor/execdesc.h:64:81: note: expected ‘ParamListInfo’ {aka ‘struct ParamListInfoData *’} but argument is of type ‘DestReceiver *’ {aka ‘struct _DestReceiver *’}
   64 |                                                                   ParamListInfo params,
      |                                                                   ~~~~~~~~~~~~~~^~~~~~
In file included from /usr/pgsql-18/include/server/nodes/execnodes.h:38,
                 from /usr/pgsql-18/include/server/catalog/indexing.h:19,
                 from src/tleextension.c:48:
/usr/pgsql-18/include/server/nodes/params.h:98:35: note: ‘ParamListInfo’ declared here
   98 | typedef struct ParamListInfoData *ParamListInfo;
      |                                   ^~~~~~~~~~~~~
src/tleextension.c:1185:93: error: passing argument 8 of ‘CreateQueryDesc’ makes integer from pointer without a cast [-Wint-conversion]
 1185 |                                                                                 dest, NULL, NULL, 0);
      |                                                                                             ^~~~
      |                                                                                             |
      |                                                                                             void *
/usr/pgsql-18/include/server/executor/execdesc.h:66:71: note: expected ‘int’ but argument is of type ‘void *’
   66 |                                                                   int instrument_options);
      |                                                                   ~~~~^~~~~~~~~~~~~~~~~~
src/tleextension.c:1179:41: error: too many arguments to function ‘CreateQueryDesc’; expected 8, have 9
 1179 |                                 qdesc = CreateQueryDesc(stmt,
      |                                         ^~~~~~~~~~~~~~~
......
 1185 |                                                                                 dest, NULL, NULL, 0);
      |                                                                                                   ~
/usr/pgsql-18/include/server/executor/execdesc.h:59:19: note: declared here
   59 | extern QueryDesc *CreateQueryDesc(PlannedStmt *plannedstmt,
      |                   ^~~~~~~~~~~~~~~
make[1]: *** [<builtin>: src/tleextension.o] Error 1
src/passcheck.c:84:13: warning: no previous declaration for ‘pass_types’ [-Wmissing-variable-declarations]
   84 | char       *pass_types[3] = {"PASSWORD_TYPE_PLAINTEXT", "PASSWORD_TYPE_MD5", "PASSWORD_TYPE_SCRAM_SHA_256"};
      |             ^~~~~~~~~~
src/datatype.c: In function ‘pg_tle_create_base_type_internal’:
src/datatype.c:231:23: warning: variable ‘address’ set but not used [-Wunused-but-set-variable]
  231 |         ObjectAddress address;

[anth0nyleung]

Hi @devrimgunduz, just to clarify - are you using 1.5.1? The fix is merged in mainline for this issue - 8ef55c0.

[devrimgunduz]

Hi @anth0nyleung,

Yes. We build packages only from released tarballs.

So the next question: When will a new release be out?

[anth0nyleung]

We have cut a new tag 1.5.2 which is compatible with 18.0.

[devrimgunduz]

Appreciated, thanks! I'm about to push RPMs to PGDG RPM repository.

Just for the records, getting some build warnings against GCC 15. Just wanted to report:

/usr/bin/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -Wno-format-truncation -O2  -I./include -I. -I./ -I/usr/pgsql-18/include/server -I/usr/pgsql-18/include/internal -D_GNU_SOURCE  -I/usr/include -I/usr/include/libxml2 -DWITH_GZFILEOP    -flto=thin -emit-llvm -c -o src/guc-file.bc src/guc-file.c
src/passcheck.c:84:13: warning: no previous declaration for ‘pass_types’ [-Wmissing-variable-declarations]
   84 | char       *pass_types[3] = {"PASSWORD_TYPE_PLAINTEXT", "PASSWORD_TYPE_MD5", "PASSWORD_TYPE_SCRAM_SHA_256"};
      |             ^~~~~~~~~~
src/datatype.c: In function ‘pg_tle_create_base_type_internal’:
src/datatype.c:231:23: warning: variable ‘address’ set but not used [-Wunused-but-set-variable]
  231 |         ObjectAddress address;
      |                       ^~~~~~~
src/tleextension.c:138:17: warning: no previous declaration for ‘cb_registered’ [-Wmissing-variable-declarations]
  138 | bool            cb_registered = false;
      |                 ^~~~~~~~~~~~~
src/tleextension.c:141:17: warning: no previous declaration for ‘tleart’ [-Wmissing-variable-declarations]
  141 | bool            tleart = false;
      |                 ^~~~~~
src/tleextension.c:157:17: warning: no previous declaration for ‘tleext’ [-Wmissing-variable-declarations]
  157 | bool            tleext = false;
      |                 ^~~~~~