ci: remove build-dashboard action from PR flow #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue here: aws#3763. This action does not run, since the issue-dashboard relies on node 12, which is deprecated and no longer runs in GH actions. This commit entirely removes the workflow. Once the team has a solution this commit will likely be reverted and the action added back in, but rather than just temporarily disabling it I think it's cleaner to just entirely remove it while it's broken.
maddeleine
approved these changes
Jan 18, 2023
This reverts commit 94a41cc.
jmayclin
changed the title
I read the message wrong. The node deprecation thing is just a warning and not an error. Thus we don't have to delete the whole thing. I still hate the idea of note knowing whether an action is going to succeed before I click merge though, so now going with this appraoch. Honestly, I'd like to do the same thing for our documentation, but probably going to get more pushback on that.
jmayclin
force-pushed
the
remove-build-dashboard
branch
from
f28cf33
to
413c202
Compare
maddeleine
approved these changes
Jan 19, 2023
|
https://github.com/aws/s2n-tls/pulls?q=is%3Apr+is%3Aclosed+ It looks like about 1/2 of the build dashboard actions fail |
|
Cause for the failures #3775 |
|
Ok, short term this will work, but the dashboards freshness does down. A better solution from #3775 is to use an action to update the gh-pages branch, which we can tackle next. |
dougch
approved these changes
Jan 25, 2023
knightjoel
pushed a commit
to knightjoel/s2n-tls
that referenced
this pull request
Jan 25, 2023
issue here: aws#3763. This CI action frequently fails, resulting in a noisy merge history that means half of the merged PR's have a "checks failed" status. As a first step, this commit removes the build-dashboard action from the PR workflow and instead schedules it to run once each weekday. Further actions are tracked in the linked issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue here: #3763. This action is flaky, likely due to a race condition between the doxygen generation and this action.
This commit removes the workflow from the PR flow, and instead schedules it as a cronjob which will run on each weekday at 00:00.
Resolved issues:
Partially addresses #3763
Description of changes:
This should prevent the irritating scenario of a merged PR being retroactively declared bad because of a failing
pr-closeaction. Also threw in a git pull for some extra synchronization.Call-Outs
I'd be in favor of doing this for the documentation generation as well, but that one doesn't seem nearly as flakey so I have less strong opinions on that.
issue-dashboardlooks to be no longer maintained, so we should be on the lookout for a replacement on that one.Testing:
no testing, ci alteration.
Revisions
Initial PR totally nuked this, turns out that was overkill because the node 12 deprecation is just a warning and not an error. In my defense, navigating around github's different actions and their corresponding failures can be a bit confusing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.