Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torchserve support for PyTorch Inference #58

Closed
wants to merge 1 commit into from
Closed

Torchserve support for PyTorch Inference #58

wants to merge 1 commit into from

Conversation

dhanainme
Copy link
Contributor

@dhanainme dhanainme commented Jul 10, 2020

Torchserve support for PyTorch Inference

This is part of 3 PRs in sagemaker-inference-toolkit / sagemaker-pytorch-inference-toolkit / dlc to add support for TorchServe in Sagmaker.

Other 2 PRs which depend on this : aws/sagemaker-pytorch-inference-toolkit#79 / aws/deep-learning-containers#347

Testing done

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
  • I have updated any necessary documentation, including READMEs

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-inference-toolkit-pr
  • Commit ID: 2bb3871
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@@ -0,0 +1,163 @@
# Copyright 2019-2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is designed to be framework agnostic.
Torchserve belongs either in pytorch-serving or in its own repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this PR as this has been moved to aws/sagemaker-pytorch-inference-toolkit#79

@dhanainme dhanainme closed this Jul 15, 2020
Copy link

@zoran-hristov zoran-hristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants