Skip to content

Conversation

laurenyu
Copy link
Contributor

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@icywang86rui icywang86rui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-io
Copy link

codecov-io commented Jun 26, 2018

Codecov Report

Merging #257 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage    92.4%   92.58%   +0.18%     
==========================================
  Files          49       49              
  Lines        3277     3277              
==========================================
+ Hits         3028     3034       +6     
+ Misses        249      243       -6
Impacted Files Coverage Δ
src/sagemaker/local/image.py 88.56% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0efeacf...f95d571. Read the comment docs.

@laurenyu laurenyu merged commit 143357e into aws:master Jun 26, 2018
@laurenyu laurenyu deleted the 1.5.1 branch June 26, 2018 20:15
knakad pushed a commit to knakad/sagemaker-python-sdk that referenced this pull request Nov 27, 2019
Introduce AutoML feature PySDK support.
knakad pushed a commit to knakad/sagemaker-python-sdk that referenced this pull request Dec 4, 2019
Introduce AutoML feature PySDK support.
knakad pushed a commit that referenced this pull request Dec 4, 2019
Introduce AutoML feature PySDK support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants