Skip to content

feature: Add support for Hugging Face 4.10.2 #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 8, 2021

Conversation

saimidu
Copy link
Contributor

@saimidu saimidu commented Sep 30, 2021

Issue #, if available:

Description of changes:

  • Add support for HF 4.10.2 on TF 2.5 and PT 1.9
  • Fix bug in HF Estimator that prevents input py_version parameter from propagating to parent class functions
  • Fix bug in HF test utils that force py version to be py36 instead of being variable

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@shreyapandit shreyapandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation for pythn versioning should use a different attribute for checking, synced with @saimidu offline for the same

Copy link
Contributor

@shreyapandit shreyapandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained in comment

Copy link
Member

@mufaddal-rohawala mufaddal-rohawala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing, need to fix that, otherwise LGTM.
ERROR: black-check: parallel child exit code 1

@ahsan-z-khan
Copy link
Member

image

Merging as Notebook tests passed locally. failed due to error not related to this PR.

@ahsan-z-khan ahsan-z-khan merged commit fc2711e into aws:master Oct 8, 2021
@saimidu saimidu deleted the huggingface_new_images branch October 8, 2021 18:21
@saimidu
Copy link
Contributor Author

saimidu commented Oct 8, 2021

Thank you for the reviews.

EthanShouhanCheng pushed a commit to SissiChenxy/sagemaker-python-sdk that referenced this pull request Jan 11, 2022
Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com>
Co-authored-by: Tabassum <jeniyat@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants