audit docstring and function signature arg type for workflow classes #2967

jerrypeng7773 · 2022-03-03T19:50:03Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…2935)

Co-authored-by: Navin Soni <navinsoni89@gmail.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> Co-authored-by: HappyAmazonian <91216626+HappyAmazonian@users.noreply.github.com>

Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: Navin Soni <navinsoni89@gmail.com>

) Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>

…into aws-master

sagemaker-bot · 2022-03-03T20:13:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 67e22b4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-03-03T20:27:02Z

Codecov Report

Merging #2967 (4cef9c8) into master (77792ed) will decrease coverage by 0.15%.
The diff coverage is 94.33%.

❗ Current head 4cef9c8 differs from pull request most recent head 22fced2. Consider uploading reports for the commit 22fced2 to get more accurate results

@@            Coverage Diff             @@
##           master    #2967      +/-   ##
==========================================
- Coverage   89.97%   89.82%   -0.16%     
==========================================
  Files        1028      196     -832     
  Lines       83918    16575   -67343     
==========================================
- Hits        75504    14888   -60616     
+ Misses       8414     1687    -6727

Impacted Files	Coverage Δ
src/sagemaker/huggingface/estimator.py	`91.86% <ø> (ø)`
src/sagemaker/session.py	`70.39% <ø> (-0.08%)`	⬇️
src/sagemaker/training_compiler/config.py	`86.11% <ø> (ø)`
src/sagemaker/workflow/pipeline.py	`89.26% <ø> (ø)`
src/sagemaker/workflow/utilities.py	`100.00% <ø> (ø)`
src/sagemaker/serializers.py	`92.91% <78.57%> (ø)`
src/sagemaker/model.py	`91.79% <100.00%> (-0.32%)`	⬇️
src/sagemaker/workflow/_repack_model.py	`100.00% <100.00%> (ø)`
src/sagemaker/workflow/_utils.py	`88.28% <100.00%> (+0.37%)`	⬆️
src/sagemaker/workflow/callback_step.py	`97.95% <100.00%> (ø)`
... and 858 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77792ed...22fced2. Read the comment docs.

sagemaker-bot · 2022-03-03T20:52:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 67e22b4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-03T22:19:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 67e22b4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…into aws-master

sagemaker-bot · 2022-03-07T23:13:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 24569de
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-07T23:46:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 24569de
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-08T01:02:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 24569de
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/workflow/step_collections.py

src/sagemaker/workflow/condition_step.py

src/sagemaker/workflow/_utils.py

sagemaker-bot · 2022-03-11T23:33:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5ffcb5c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-12T00:28:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5ffcb5c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-12T00:48:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5ffcb5c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-14T16:35:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4cef9c8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-14T17:13:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4cef9c8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-14T18:06:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4cef9c8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2022-03-18T00:47:29Z

@jerrypeng7773 can you rebase with aws/master to resolve conflicts?

…into doc-audit

sagemaker-bot · 2022-03-18T19:04:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 33719b6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T20:02:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 33719b6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ahsan-z-khan

@jerrypeng7773 can you rebase? readthedocs check is failing as it doesn't have the latest change

sagemaker-bot · 2022-03-18T23:03:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 22fced2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-19T00:09:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 22fced2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jerrypeng7773 · 2022-03-19T00:20:52Z

This commit has some corrupted commits, will cancel it in favor of this
#3013

sagemaker-bot · 2022-03-19T01:34:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 22fced2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

MadhubalasriB and others added 12 commits February 22, 2022 02:25

feature: adding customer metadata support to registermodel step (aws#…

1cbfe50

…2935)

fix: Support primitive types for left value of ConditionSteps (aws#2886)

a98a6d8

Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: Navin Soni <navinsoni89@gmail.com>

fix: Add lineage doc (aws#2937)

a928c0a

fix: update lineage_trial_compoment get pipeline execution arn (aws#2944

668359f

) Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com>

fix: Improve Pipeline workflow unit test branch coverage (aws#2878)

0e4fd55

Co-authored-by: Dewen Qi <qidewen@amazon.com>

Implement subclass compatibility for workflow pipeline job steps

02619cb

Merge branch 'master' of https://github.com/aws/sagemaker-python-sdk …

62dd621

…into aws-master

Merge branch 'aws-master'

2b0b173

fix formatting

2b89f93

audit docstring and function signature arg type

67e22b4

jerrypeng7773 requested review from navaj0 and qidewenwhen March 3, 2022 20:24

Merge branch 'master' of https://github.com/aws/sagemaker-python-sdk …

f5199e9

…into aws-master

navaj0 reviewed Mar 9, 2022

View reviewed changes

fix docstring

5ffcb5c

jerrypeng7773 force-pushed the doc-audit branch from 24569de to 5ffcb5c Compare March 11, 2022 23:09

ahsan-z-khan changed the base branch from dev to master March 14, 2022 16:12

jerrypeng7773 added 3 commits March 18, 2022 11:45

Merge branch 'master' of https://github.com/aws/sagemaker-python-sdk …

70b2e3e

…into doc-audit

Merge branch 'aws-master' into doc-audit

4a54ac3

re-formatting

33719b6

jerrypeng7773 force-pushed the doc-audit branch from 4cef9c8 to 33719b6 Compare March 18, 2022 18:58

ahsan-z-khan suggested changes Mar 18, 2022

View reviewed changes

fix docstring

22fced2

jerrypeng7773 closed this Mar 19, 2022

audit docstring and function signature arg type for workflow classes #2967

audit docstring and function signature arg type for workflow classes #2967

Uh oh!

Conversation

jerrypeng7773 commented Mar 3, 2022

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Mar 3, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Mar 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Mar 3, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 3, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2022

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented Mar 11, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 14, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 14, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 14, 2022

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Mar 18, 2022

Uh oh!

sagemaker-bot commented Mar 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 18, 2022

AWS CodeBuild CI Report

Uh oh!

ahsan-z-khan left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Mar 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 19, 2022

AWS CodeBuild CI Report

Uh oh!

jerrypeng7773 commented Mar 19, 2022

Uh oh!

sagemaker-bot commented Mar 19, 2022

AWS CodeBuild CI Report

Uh oh!

Uh oh!

codecov-commenter commented Mar 3, 2022 •

edited

Loading