Add variant_name kwarg #3161

hardianlawi · 2022-06-07T08:36:52Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-06-07T08:40:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5a3b31d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-07T09:12:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5a3b31d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-07T09:24:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5a3b31d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-07T09:26:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5a3b31d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-07T09:44:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5a3b31d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run all

sagemaker-bot · 2022-11-27T21:24:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8fa41f3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-27T21:49:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8fa41f3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-11-27T21:49:50Z

Codecov Report

Merging #3161 (fe44ffc) into master (cadd0a1) will decrease coverage by 0.95%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

❗ Current head fe44ffc differs from pull request most recent head 8edcfb6. Consider uploading reports for the commit 8edcfb6 to get more accurate results

@@            Coverage Diff             @@
##           master    #3161      +/-   ##
==========================================
- Coverage   90.19%   89.24%   -0.95%     
==========================================
  Files        1296      267    -1029     
  Lines      115184    26021   -89163     
==========================================
- Hits       103892    23223   -80669     
+ Misses      11292     2798    -8494

Files Changed	Coverage Δ
src/sagemaker/huggingface/model.py	`89.87% <ø> (ø)`
src/sagemaker/model.py	`93.71% <ø> (ø)`
src/sagemaker/multidatamodel.py	`88.54% <ø> (ø)`

... and 1560 files with indirect coverage changes

sagemaker-bot · 2022-11-27T22:00:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8fa41f3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-27T22:16:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8fa41f3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-27T22:27:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8fa41f3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run slow-tests

vikas0203

/bot run unit-tests

sagemaker-bot · 2022-11-30T03:30:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8fa41f3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-30T05:51:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8fa41f3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run all

sagemaker-bot · 2022-12-01T04:15:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d236194
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-01T04:55:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d236194
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-01T05:16:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d236194
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-01T05:17:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d236194
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run unit-tests

sagemaker-bot · 2022-12-22T01:21:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d236194
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

npow · 2023-02-03T01:26:25Z

Hi, any idea when this will be merged in master? It's been open for ~6 months now.

vikas0203

/bot run unit-tests

sagemaker-bot · 2023-02-08T19:23:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d236194
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run unit-tests

sagemaker-bot · 2023-02-11T00:05:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d236194
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-05-09T01:40:06Z

src/sagemaker/huggingface/model.py

        deserializer=None,
        accelerator_type=None,
        endpoint_name=None,
+        variant_name="AllTraffic",


Since this is a new argument, can we add this at the end of argument list? This is to ensure backwards compatibility for existing usages for our customers.

mufaddal-rohawala · 2023-05-09T01:42:21Z

Apologies for late comment, but we will be taking of tracking this PR to completion.

mufaddal-rohawala

/bot run all

sagemaker-bot · 2023-05-12T01:14:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: fe44ffc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-12T01:17:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: fe44ffc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-12T01:18:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: fe44ffc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-12T01:22:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: fe44ffc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-12T01:31:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: fe44ffc
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run all

mufaddal-rohawala · 2023-08-18T22:18:58Z

Due to low response on addressing the PR comments, we are going to close this pull-request. We will keep the associated issue open to track and fix using this PR for referrence.

sagemaker-bot · 2023-08-18T23:00:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8edcfb6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-18T23:13:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8edcfb6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-18T23:19:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8edcfb6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-18T23:25:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8edcfb6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-18T23:50:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8edcfb6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell force-pushed the add-variant-name-kwarg branch from 512debe to 8fa41f3 Compare October 19, 2022 17:18

vikas0203 requested review from a team, vikas0203 and mufaddal-rohawala and removed request for a team November 23, 2022 21:25

vikas0203 self-assigned this Nov 23, 2022

vikas0203 approved these changes Nov 27, 2022

View reviewed changes

vikas0203 reviewed Nov 27, 2022

View reviewed changes

vikas0203 reviewed Nov 30, 2022

View reviewed changes

Add variant_name kwarg

d236194

vikas0203 force-pushed the add-variant-name-kwarg branch from 8fa41f3 to d236194 Compare December 1, 2022 04:07

vikas0203 reviewed Dec 1, 2022

View reviewed changes

mufaddal-rohawala requested a review from a team as a code owner December 20, 2022 00:31

vikas0203 reviewed Dec 22, 2022

View reviewed changes

vikas0203 reviewed Feb 8, 2023

View reviewed changes

vikas0203 reviewed Feb 10, 2023

View reviewed changes

knikure assigned mufaddal-rohawala and unassigned vikas0203 May 2, 2023

Merge branch 'master' into add-variant-name-kwarg

27f9567

mufaddal-rohawala reviewed May 9, 2023

View reviewed changes

Merge branch 'master' into add-variant-name-kwarg

fe44ffc

mufaddal-rohawala reviewed May 12, 2023

View reviewed changes

mufaddal-rohawala added 2 commits August 2, 2023 09:46

Merge branch 'master' into add-variant-name-kwarg

9a521ce

Merge branch 'master' into add-variant-name-kwarg

8edcfb6

mufaddal-rohawala reviewed Aug 18, 2023

View reviewed changes

mufaddal-rohawala closed this Aug 18, 2023

Add variant_name kwarg #3161

Add variant_name kwarg #3161

Uh oh!

Conversation

hardianlawi commented Jun 7, 2022

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jun 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 7, 2022

AWS CodeBuild CI Report

Uh oh!

vikas0203 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Nov 27, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 27, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Nov 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Nov 27, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 27, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 27, 2022

AWS CodeBuild CI Report

Uh oh!

vikas0203 left a comment

Choose a reason for hiding this comment

Uh oh!

vikas0203 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Nov 30, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 30, 2022

AWS CodeBuild CI Report

Uh oh!

vikas0203 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Dec 1, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 1, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 1, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 1, 2022

AWS CodeBuild CI Report

Uh oh!

vikas0203 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Dec 22, 2022

AWS CodeBuild CI Report

Uh oh!

npow commented Feb 3, 2023

codecov-commenter commented Nov 27, 2022 •

edited

Loading

mufaddal-rohawala May 9, 2023 •

edited

Loading