Skip to content

fix: pass default_bucket to Session object in LocalSession class construct #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

fix: pass default_bucket to Session object in LocalSession class construct #3171

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
94b6b8e
fix: pass `default_bucket` to `Session` object in `LocalSession` clas…
Jun 15, 2022
1f8fd14
Merge branch 'master' of github.com:aws/sagemaker-python-sdk
Jun 21, 2022
fea9ab3
Merge branch 'aws:master' into master
hossein-jazayeri Jun 21, 2022
07fbab4
Merge branch 'master' of github.com:hossein-jazayeri/sagemaker-python…
Jun 21, 2022
658da8a
fix code format
Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/sagemaker/local/local_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,9 @@ class LocalSession(Session):
:class:`~sagemaker.session.Session`.
"""

def __init__(self, boto_session=None, s3_endpoint_url=None, disable_local_code=False):
def __init__(
self, boto_session=None, s3_endpoint_url=None, disable_local_code=False, default_bucket=None
):
"""Create a Local SageMaker Session.

Args:
Expand All @@ -503,14 +505,20 @@ def __init__(self, boto_session=None, s3_endpoint_url=None, disable_local_code=F
disable_local_code (bool): Set ``True`` to override the default AWS configuration
chain to disable the ``local.local_code`` setting, which may not be supported for
some SDK features (default: False).
default_bucket (str): The default Amazon S3 bucket to be used by this session.
This will be created the next time an Amazon S3 bucket is needed (by calling
:func:`default_bucket`).
If not provided, a default bucket will be created based on the following format:
"sagemaker-{region}-{aws-account-id}".
Example: "sagemaker-my-custom-bucket".
"""
self.s3_endpoint_url = s3_endpoint_url
# We use this local variable to avoid disrupting the __init__->_initialize API of the
# parent class... But overwriting it after constructor won't do anything, so prefix _ to
# discourage external use:
self._disable_local_code = disable_local_code

super(LocalSession, self).__init__(boto_session)
super(LocalSession, self).__init__(boto_session, default_bucket=default_bucket)

if platform.system() == "Windows":
logger.warning("Windows Support for Local Mode is Experimental")
Expand Down