Skip to content

documentation: Fix tensorflow and pytorch supported version in HuggingFaceProcessor #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2023
Merged

documentation: Fix tensorflow and pytorch supported version in HuggingFaceProcessor #3281

merged 1 commit into from
May 18, 2023

Conversation

KangBK0120
Copy link
Contributor

@KangBK0120 KangBK0120 commented Aug 5, 2022 •
edited
Loading

Issue #, if available:

Description of changes:

image

There are conflicts between the specified version in docstring and the actual implementation. This PR fixes the docstring of the HuggingFaceProcessor to match actual implementation.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@claytonparnell claytonparnell force-pushed the fix-huggingface-processor-docstring branch from 1ee1e2d to c6ed883 Compare October 19, 2022 17:15
@vikas0203 vikas0203 requested review from a team, trajanikant and claytonparnell and removed request for a team November 23, 2022 21:26
@trajanikant trajanikant force-pushed the fix-huggingface-processor-docstring branch from c6ed883 to 7819689 Compare November 30, 2022 23:48
trajanikant
trajanikant reviewed Dec 5, 2022
View reviewed changes
Copy link
Contributor

@trajanikant trajanikant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7819689
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 7819689
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022 •
edited
Loading

Codecov Report

Merging #3281 (66d6525) into master (0f37695) will decrease coverage by 0.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3281      +/-   ##
==========================================
- Coverage   89.96%   89.25%   -0.72%     
==========================================
  Files        1140      267     -873     
  Lines      105744    26132   -79612     
==========================================
- Hits        95129    23323   -71806     
+ Misses      10615     2809    -7806
Impacted Files Coverage Δ
src/sagemaker/huggingface/processing.py 100.00% <ø> (ø)

... and 1406 files with indirect coverage changes

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7819689
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 7819689
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 7819689
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala mufaddal-rohawala requested a review from a team as a code owner December 20, 2022 00:31
@trajanikant trajanikant force-pushed the fix-huggingface-processor-docstring branch from 7819689 to 8303611 Compare March 28, 2023 00:19
@knikure knikure force-pushed the fix-huggingface-processor-docstring branch from 8303611 to 66d6525 Compare May 18, 2023 17:56
@knikure knikure self-assigned this May 18, 2023
knikure
knikure reviewed May 18, 2023
View reviewed changes
Copy link
Contributor

@knikure knikure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 66d6525
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 66d6525
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 66d6525
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 66d6525
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 66d6525
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure merged commit ab123a1 into aws:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claytonparnell claytonparnell Awaiting requested review from claytonparnell claytonparnell is a code owner automatically assigned from aws/sagemaker-ml-frameworks

2 more reviewers

@trajanikant trajanikant trajanikant left review comments

@knikure knikure knikure approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@trajanikant trajanikant

@knikure knikure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KangBK0120 @sagemaker-bot @codecov-commenter @trajanikant @knikure