change: remove unused dependency protobuf3-to-dict #3404

zenogantner · 2022-10-10T15:52:57Z

Description of changes:

protobuf3-to-dict is not used by the SageMaker Python SDK, as far as I can tell.

No occurrence in the source code:

> ag protobuf_to_dict
doc/frameworks/tensorflow/upgrade_from_legacy.rst
230:    from protobuf_to_dict import protobuf_to_dict
240:    protobuf_to_dict(json_format.Parse(result, tensor_pb2.TensorProto()))

This dependency has not been updated since 2017 and causes issues in certain combinations of poetry and pyenv. I suggest to remove it.

Testing done:

Ran local tests with Python 3.10, output looked okay.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

claytonparnell

/bot run all

sagemaker-bot · 2022-10-12T17:40:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8d93191
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-12T18:05:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8d93191
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-12T18:19:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8d93191
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-12T18:29:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8d93191
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-10-12T18:30:26Z

Codecov Report

❗ No coverage uploaded for pull request base (master@5d59767). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3404   +/-   ##
=========================================
  Coverage          ?   88.87%           
=========================================
  Files             ?      212           
  Lines             ?    20481           
  Branches          ?        0           
=========================================
  Hits              ?    18202           
  Misses            ?     2279           
  Partials          ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-10-12T18:38:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8d93191
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

zenogantner · 2022-10-12T19:01:35Z

2 questions:

sagemaker-python-sdk-slow-tests failed -- is the failure related to the change, or a false alarm (I could not log in to see this with my usual AWS credentials, but I could try to dig deeper)?
Should I (or someone else) update the branch?

claytonparnell

/bot run all

sagemaker-bot · 2022-10-21T21:17:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e5b7889
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-21T21:42:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e5b7889
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-21T22:00:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e5b7889
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-21T22:07:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e5b7889
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-21T22:18:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e5b7889
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run slow-tests

sagemaker-bot · 2022-10-24T16:21:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 70e154d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run local-mode-tests, notebook-tests, pr, unit-tests

sagemaker-bot · 2022-10-24T18:36:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 70e154d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-24T18:49:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 70e154d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-24T18:56:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 70e154d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-24T19:08:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 70e154d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

zenogantner · 2022-11-16T10:54:26Z

sagemaker-python-sdk-pr failed 23 days ago. Logs are available for 7 more days.

Given that different test runs failed at different times -- are these somewhat flaky tests?

sagemaker-bot · 2022-11-28T21:59:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 70e154d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-28T22:23:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 70e154d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-28T23:56:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 70e154d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run notebook-tests

sagemaker-bot · 2022-11-29T23:26:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 70e154d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run slow-tests

sagemaker-bot · 2022-11-30T05:40:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 70e154d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Mufaddal Rohawala <muffi179@gmail.com>

Co-authored-by: Basil Beirouti <BasilBeirouti@gmail.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>

…aws#3438) Co-authored-by: Keshav Chandak <chakesh@amazon.com>

Co-authored-by: Navin Soni <navinns@amazon.com>

No occurrence in the source code: ```shell > ag protobuf_to_dict doc/frameworks/tensorflow/upgrade_from_legacy.rst 230: from protobuf_to_dict import protobuf_to_dict 240: protobuf_to_dict(json_format.Parse(result, tensor_pb2.TensorProto())) ``` This dependency has not been updated since 2017 and causes issues in certain combinations of poetry and pyenv. I suggest to remove it.

vikas0203

/bot run all

sagemaker-bot · 2022-12-02T23:13:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d579204
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T23:19:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d579204
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T23:19:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d579204
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T23:44:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d579204
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-03T00:46:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d579204
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure · 2023-05-18T17:45:13Z

@zenogantner Thanks for taking up this change.
I have created another PR #3869 to accommodate this change. Hence closing this PR.

claytonparnell approved these changes Oct 11, 2022

View reviewed changes

claytonparnell reviewed Oct 12, 2022

View reviewed changes

claytonparnell force-pushed the remove-protobuf3-to-dict-dependency branch from 8d93191 to e5b7889 Compare October 19, 2022 17:11

claytonparnell approved these changes Oct 21, 2022

View reviewed changes

claytonparnell reviewed Oct 21, 2022

View reviewed changes

claytonparnell reviewed Oct 24, 2022

View reviewed changes

vikas0203 requested review from a team, vikas0203 and knikure and removed request for a team November 23, 2022 20:24

vikas0203 self-assigned this Nov 23, 2022

vikas0203 reviewed Nov 29, 2022

View reviewed changes

vikas0203 reviewed Nov 30, 2022

View reviewed changes

NivekNey and others added 10 commits December 2, 2022 12:48

fix: type hint of PySparkProcessor __init__ (aws#3297)

c97c467

fix: fix PySparkProcessor __init__ params type (aws#3354)

de58941

fix: Allow Py 3.7 for MMS Test Docker env (aws#3080)

41dd330

Co-authored-by: Mufaddal Rohawala <muffi179@gmail.com>

refactoring : using with statement (aws#3286)

1e23a3f

Update local_requirements.txt PyYAML version (aws#3095)

19efadf

Co-authored-by: Basil Beirouti <BasilBeirouti@gmail.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>

feature: Update TF 2.9 and TF 2.10 inference DLCs (aws#3465)

76f7782

feature: Added transform with monitoring pipeline step in transformer (…

fde0738

…aws#3438) Co-authored-by: Keshav Chandak <chakesh@amazon.com>

fix: Fix bug forcing uploaded tar to be named sourcedir (aws#3412)

7f9f3b0

feature: Add Code Owners file (aws#3503)

5d59767

Co-authored-by: Navin Soni <navinns@amazon.com>

vikas0203 force-pushed the remove-protobuf3-to-dict-dependency branch from 70e154d to d579204 Compare December 2, 2022 22:36

vikas0203 requested a review from a team as a code owner December 2, 2022 22:36

vikas0203 reviewed Dec 2, 2022

View reviewed changes

mufaddal-rohawala force-pushed the master branch from bae3b8b to d000bdc Compare December 20, 2022 00:31

knikure assigned knikure and unassigned vikas0203 May 1, 2023

knikure closed this May 18, 2023

change: remove unused dependency protobuf3-to-dict #3404

change: remove unused dependency protobuf3-to-dict #3404

Uh oh!

Conversation

zenogantner commented Oct 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Uh oh!

claytonparnell left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Oct 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 12, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Oct 12, 2022

AWS CodeBuild CI Report

Uh oh!

zenogantner commented Oct 12, 2022

Uh oh!

claytonparnell left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

Uh oh!

claytonparnell left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Oct 24, 2022

AWS CodeBuild CI Report

Uh oh!

claytonparnell left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Oct 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 24, 2022

AWS CodeBuild CI Report

Uh oh!

zenogantner commented Nov 16, 2022

Uh oh!

sagemaker-bot commented Nov 28, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 28, 2022

AWS CodeBuild CI Report

Uh oh!

zenogantner commented Oct 10, 2022 •

edited

Loading

codecov-commenter commented Oct 12, 2022 •

edited

Loading