fix: add environment key to model container only if it is not empty #3457

l3ku · 2022-11-04T09:54:19Z

Issue #, if available:
#3397

Description of changes:
Removed defaulting to empty environment variables in the container definition to be provided to the CreateModelPackage API call. The empty dict caused a problem when trying to create a model (CreateModel API call) with some environment variables so that the model package can be used in an endpoint: environment variable map cannot be specified both at Model Package {} and Model {...}.

Fixes: #3397

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mufaddal-rohawala

/bot run all

sagemaker-bot · 2022-11-16T01:08:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-11-16T01:13:49Z

Codecov Report

Merging #3457 (cdd4ac7) into master (1fa2377) will decrease coverage by 0.29%.
The diff coverage is 87.26%.

❗ Current head cdd4ac7 differs from pull request most recent head c2201b7. Consider uploading reports for the commit c2201b7 to get more accurate results

@@            Coverage Diff             @@
##           master    #3457      +/-   ##
==========================================
- Coverage   89.17%   88.87%   -0.30%     
==========================================
  Files         204      212       +8     
  Lines       18979    20482    +1503     
==========================================
+ Hits        16924    18203    +1279     
- Misses       2055     2279     +224

Impacted Files	Coverage Δ
src/sagemaker/feature_store/feature_group.py	`76.52% <ø> (ø)`
src/sagemaker/huggingface/model.py	`89.87% <ø> (ø)`
src/sagemaker/pipeline.py	`85.33% <ø> (ø)`
src/sagemaker/sklearn/model.py	`92.98% <ø> (-1.76%)`	⬇️
src/sagemaker/sparkml/model.py	`100.00% <ø> (ø)`
...sagemaker/workflow/monitor_batch_transform_step.py	`0.00% <0.00%> (ø)`
src/sagemaker/xgboost/model.py	`96.36% <ø> (-1.82%)`	⬇️
...agemaker/model_monitor/clarify_model_monitoring.py	`89.84% <27.58%> (-5.09%)`	⬇️
src/sagemaker/transformer.py	`85.41% <40.62%> (-9.07%)`	⬇️
.../sagemaker/huggingface/training_compiler/config.py	`90.47% <50.00%> (ø)`
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-11-16T01:13:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-16T01:30:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-16T01:31:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 40add6a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-16T01:33:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run all

sagemaker-bot · 2022-11-23T21:18:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-23T21:19:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-23T21:29:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-23T21:39:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-23T21:43:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run all

sagemaker-bot · 2022-11-24T06:15:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-24T06:16:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-24T06:23:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-24T06:33:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-24T06:49:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run all

sagemaker-bot · 2022-11-25T19:12:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-25T19:43:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-25T19:45:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-25T20:01:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 40add6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run unit-tests

sagemaker-bot · 2022-12-12T20:14:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: cdd4ac7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…aws#3530) Currently the analysis configuration schema of SageMaker Clarify API allows the content_type configuration "image/jpeg" and "image/jpg", but the service side validation only accepts the former which is the registered MIME type for JPEG (see rfc3745 and JPEG specification). The commit removes the latter from the schema to avoid confusion and enable early API validation.

Co-authored-by: Anton Repushko <repuanto@amazon.com>

…st_feature_group (aws#3534) Co-authored-by: Eric Zou <zoueric@amazon.com> Co-authored-by: Yiming Zou <imingtsou@gmail.com> Co-authored-by: Brandon Chatham <bdchatham@gmail.com> Co-authored-by: jiapinw <95885824+jiapinw@users.noreply.github.com>

mufaddal-rohawala · 2023-08-14T16:43:14Z

@l3ku can you help rebase this PR with latest master and resolve conflicts?

mufaddal-rohawala · 2023-08-18T22:10:00Z

Closing this PR as it has not been updated for some time. The issue request will be kept open and will continue to track the fix here.

l3ku · 2023-09-05T13:33:34Z

I resolved the issue since it seems that this issue no longer exists due to a change in the AWS SageMaker APIs.

mufaddal-rohawala requested a review from vikas0203 November 15, 2022 23:58

mufaddal-rohawala reviewed Nov 16, 2022

View reviewed changes

mufaddal-rohawala assigned vikas0203 Nov 16, 2022

vikas0203 requested review from a team and claytonparnell and removed request for a team November 23, 2022 20:40

vikas0203 reviewed Nov 23, 2022

View reviewed changes

vikas0203 reviewed Nov 24, 2022

View reviewed changes

vikas0203 approved these changes Nov 25, 2022

View reviewed changes

vikas0203 reviewed Nov 25, 2022

View reviewed changes

ci and others added 7 commits December 9, 2022 06:20

prepare release v2.121.1

959ea1a

update development version to v2.121.2.dev0

b2e8b66

fix: Skip Bad Transform Test (aws#3521)

355975d

fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)

fadc817

change: Update for Tensorflow Serving 2.11 inference DLCs (aws#3509)

c5fc93f

prepare release v2.121.2

ec8da98

update development version to v2.121.3.dev0

0352122

vikas0203 reviewed Dec 12, 2022

View reviewed changes

kace and others added 8 commits December 12, 2022 17:21

feature: Add OSU region to frameworks for DLC (aws#3532)

d6c0214

fix: unpin packaging version (aws#3533)

4389847

fix: the Hyperband support fix for the HPO (aws#3516)

a3efddf

Co-authored-by: Anton Repushko <repuanto@amazon.com>

prepare release v2.122.0

fb3880f

update development version to v2.122.1.dev0

a584ea5

Merge branch 'master' into master

8df713d

mufaddal-rohawala force-pushed the master branch from bae3b8b to d000bdc Compare December 20, 2022 00:31

Leo Toikka added 4 commits December 22, 2022 20:33

Merge remote-tracking branch 'origin/master'

ae15a2d

Merge remote-tracking branch 'origin/master'

58c44bf

Merge remote-tracking branch 'origin/master'

6571a88

Merge remote-tracking branch 'origin/master'

c2201b7

knikure assigned claytonparnell and unassigned vikas0203 May 2, 2023

mufaddal-rohawala self-assigned this Aug 14, 2023

mufaddal-rohawala approved these changes Aug 14, 2023

View reviewed changes

mufaddal-rohawala closed this Aug 18, 2023

fix: add environment key to model container only if it is not empty #3457

fix: add environment key to model container only if it is not empty #3457

Uh oh!

Conversation

l3ku commented Nov 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

mufaddal-rohawala left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Nov 16, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Nov 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Nov 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 16, 2022

AWS CodeBuild CI Report

Uh oh!

vikas0203 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Nov 23, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 23, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 23, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 23, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 23, 2022

AWS CodeBuild CI Report

Uh oh!

vikas0203 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

Uh oh!

vikas0203 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Nov 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 25, 2022

AWS CodeBuild CI Report

Uh oh!

l3ku commented Nov 4, 2022 •

edited

Loading

codecov-commenter commented Nov 16, 2022 •

edited

Loading