Skip to content

fix: integration test in anticipate of ProfilerConfig API changes #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: integration test in anticipate of ProfilerConfig API changes #3479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/integ/test_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ def test_mxnet_with_default_profiler_config_and_profiler_rule(
)

job_description = mx.latest_training_job.describe()
if "DisableProfiler" in job_description["ProfilerConfig"]:
job_description["ProfilerConfig"].pop("DisableProfiler")
assert (
job_description["ProfilerConfig"]
== ProfilerConfig(
Expand Down Expand Up @@ -153,6 +155,8 @@ def test_mxnet_with_custom_profiler_config_then_update_rule_and_config(
)

job_description = mx.latest_training_job.describe()
if "DisableProfiler" in job_description["ProfilerConfig"]:
job_description["ProfilerConfig"].pop("DisableProfiler")
assert job_description.get("ProfilerConfig") == profiler_config._to_request_dict()
assert job_description.get("ProfilingStatus") == "Enabled"

Expand Down Expand Up @@ -221,6 +225,8 @@ def test_mxnet_with_built_in_profiler_rule_with_custom_parameters(
)

job_description = mx.latest_training_job.describe()
if "DisableProfiler" in job_description["ProfilerConfig"]:
job_description["ProfilerConfig"].pop("DisableProfiler")
assert job_description.get("ProfilingStatus") == "Enabled"
assert (
job_description.get("ProfilerConfig")
Expand Down Expand Up @@ -292,6 +298,8 @@ def test_mxnet_with_profiler_and_debugger_then_disable_framework_metrics(
)

job_description = mx.latest_training_job.describe()
if "DisableProfiler" in job_description["ProfilerConfig"]:
job_description["ProfilerConfig"].pop("DisableProfiler")
assert job_description["ProfilerConfig"] == profiler_config._to_request_dict()
assert job_description["DebugHookConfig"] == debugger_hook_config._to_request_dict()
assert job_description.get("ProfilingStatus") == "Enabled"
Expand Down