-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: cleanup temporary table in feature store dataset builder #3663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cleanup temporary table in feature store dataset builder #3663
Conversation
3142bb6
to
34fad8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bot run all
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@patrickmcarlos Are you still working on this PR? If not, can you pls close it? If you are still working on it: Can you resolve the conflicts and take latest rebase from master. To resolve formatting issues, refer below:
|
Issue #, if available:
Description of changes:
Adds a new property to the
dataset_builder
that cleans up Glue tables when usingto_dataframe
orto_csv
when the base feature group is a DataFrame. Otherwise, a new table is created, with the format "dataframe_dataframe_base_{hash}" that needs to be manually deleted.Note that the execution role when using this functionality should have permissions to DeleteTable.
Usage:
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.