Skip to content

Conversation

patrickmcarlos
Copy link
Contributor

@patrickmcarlos patrickmcarlos commented Feb 16, 2023

Issue #, if available:

Description of changes:

Adds a new property to the dataset_builder that cleans up Glue tables when using to_dataframe or to_csv when the base feature group is a DataFrame. Otherwise, a new table is created, with the format "dataframe_dataframe_base_{hash}" that needs to be manually deleted.

Note that the execution role when using this functionality should have permissions to DeleteTable.

Usage:

result_df, query = dataset_builder.with_feature_group(
    feature_group=some_dataframe,
    target_feature_name_in_base="feature-a",
).cleanup_temporary_tables(
).to_dataframe()

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@patrickmcarlos patrickmcarlos force-pushed the patmcar-cleanup-table-in-dataframe-to-csv branch from 3142bb6 to 34fad8a Compare February 28, 2023 17:29
@patrickmcarlos patrickmcarlos marked this pull request as ready for review February 28, 2023 18:38
@patrickmcarlos patrickmcarlos requested a review from a team as a code owner February 28, 2023 18:38
@patrickmcarlos patrickmcarlos requested review from vikas0203 and removed request for a team February 28, 2023 18:38
@knikure knikure requested review from knikure and removed request for vikas0203 May 2, 2023 16:18
@knikure knikure assigned knikure and unassigned vikas0203 May 2, 2023
Copy link
Contributor

@knikure knikure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 2804634
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 2804634
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 2804634
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 2804634
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 2804634
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure
Copy link
Contributor

knikure commented Sep 14, 2023

@patrickmcarlos Are you still working on this PR? If not, can you pls close it?

If you are still working on it: Can you resolve the conflicts and take latest rebase from master.

To resolve formatting issues, refer below:

  • Fix the black-check errors by running tox -e black-format command?
  • Submit your changes after successfully running ./.githooks/pre-push command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants