Update apache-airflow Version from 2.5.1 to 2.5.2 #3738

vikas0203 · 2023-03-20T23:57:50Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-03-21T00:00:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1a9d277
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T00:01:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1a9d277
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T00:01:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1a9d277
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T00:01:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1a9d277
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T00:27:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bad7e9f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T00:27:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: bad7e9f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T00:27:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bad7e9f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T00:33:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: bad7e9f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T01:21:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bad7e9f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T01:44:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4881222
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T01:44:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4881222
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T01:45:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4881222
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T01:56:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4881222
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T02:38:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4881222
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-22T17:18:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c68bea1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-22T17:18:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: c68bea1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-22T17:18:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c68bea1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-22T17:18:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c68bea1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run all

sagemaker-bot · 2023-03-22T17:27:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c68bea1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-22T17:27:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c68bea1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-22T17:27:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c68bea1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-22T17:37:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: c68bea1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-22T18:21:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c68bea1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run all

codecov-commenter · 2023-03-24T23:42:50Z

Codecov Report

Merging #3738 (b590e13) into master (07dd8ba) will decrease coverage by 0.79%.
The diff coverage is n/a.

❗ Current head b590e13 differs from pull request most recent head fa4f3f9. Consider uploading reports for the commit fa4f3f9 to get more accurate results

@@            Coverage Diff             @@
##           master    #3738      +/-   ##
==========================================
- Coverage   89.85%   89.06%   -0.79%     
==========================================
  Files         984      231     -753     
  Lines       92388    22834   -69554     
==========================================
- Hits        83012    20338   -62674     
+ Misses       9376     2496    -6880

see 1215 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-03-24T23:49:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 19d346a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run slow-tests

sagemaker-bot · 2023-03-25T00:23:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 19d346a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-25T00:29:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 19d346a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-25T00:33:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 19d346a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-25T00:36:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 19d346a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-25T02:46:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 19d346a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run slow-tests

sagemaker-bot · 2023-03-25T07:18:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 19d346a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure · 2023-03-27T15:53:34Z

requirements/extras/test_requirements.txt

 stopit==1.1.2
 # Update tox.ini to have correct version of airflow constraints file
-apache-airflow==2.5.1
+apache-airflow<=2.5.2


This should be apache-airflow==2.5.2

When I point to apache-airflow version==2.5.2. Got below dependency conflict. So thats the reason I have used <=2.5.2 version.

The conflict is caused by:
apache-airflow 2.5.2 depends on jsonschema>=4.0.0
docker-compose 1.29.2 depends on jsonschema<4 and >=2.5.1

Also, as suggested I tried with docker-compose file to 2.7.0 version - got error , It says versions available are from 1.0.0 to 1.29.2 and 1.29.2 is latest docker-compose version which we are already using.

If the whole point of doing this change is to upgrade the version to 2.5.2 then it is not making sense.

+1 on Kalyani's comment, we'l need to resolve conflicts with patched version apache-airflow==2.5.2

vikas0203

/bot run all

sagemaker-bot · 2023-03-28T23:00:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: fa4f3f9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-28T23:00:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: fa4f3f9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-28T23:00:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: fa4f3f9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-28T23:01:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: fa4f3f9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T00:07:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: fa4f3f9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203 requested a review from a team as a code owner March 20, 2023 23:57

vikas0203 requested review from knikure and removed request for a team March 20, 2023 23:57

vikas0203 changed the title ~~Update test_requirements.txt~~ Update apache-airflow Version from 2.5.1 to 2.5.2 Mar 20, 2023

vikas0203 requested a review from trajanikant March 20, 2023 23:59

vikas0203 commented Mar 22, 2023

View reviewed changes

vikas0203 commented Mar 24, 2023

View reviewed changes

vikas0203 added 9 commits March 24, 2023 16:41

Update test_requirements.txt

b3a71f0

Update tox.ini

9942a78

Update local_requirements.txt

5d6c1eb

Update local_requirements.txt

4926bdd

Update local_requirements.txt

9111783

Update local_requirements.txt

9f011c9

Update local_requirements.txt

d99c89c

Update local_requirements.txt

dcb3267

Update test_requirements.txt

19d346a

trajanikant force-pushed the Branch2 branch from b590e13 to 19d346a Compare March 24, 2023 23:41

vikas0203 commented Mar 24, 2023

View reviewed changes

vikas0203 commented Mar 25, 2023

View reviewed changes

knikure reviewed Mar 27, 2023

View reviewed changes

Update test_requirements.txt

fa4f3f9

vikas0203 commented Mar 28, 2023

View reviewed changes

mufaddal-rohawala assigned knikure May 9, 2023

knikure closed this May 9, 2023

Update apache-airflow Version from 2.5.1 to 2.5.2 #3738

Update apache-airflow Version from 2.5.1 to 2.5.2 #3738

Uh oh!

Conversation

vikas0203 commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2023

AWS CodeBuild CI Report

Uh oh!

vikas0203 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Mar 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2023

vikas0203 commented Mar 20, 2023 •

edited

Loading

codecov-commenter commented Mar 24, 2023 •

edited

Loading

vikas0203 Mar 28, 2023 •

edited

Loading