Skip to content

Fix changelog #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2018
Merged

Fix changelog #483

merged 2 commits into from
Nov 15, 2018

Conversation

laurenyu
Copy link
Contributor

Description of changes:
I may have merged a PR a little too quickly without checking the changelog properly.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 15, 2018

Codecov Report

Merging #483 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #483      +/-   ##
=========================================
- Coverage   93.94%   93.8%   -0.14%     
=========================================
  Files          58      58              
  Lines        4329    4329              
=========================================
- Hits         4067    4061       -6     
- Misses        262     268       +6
Impacted Files Coverage Δ
src/sagemaker/local/image.py 88.08% <0%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4153e41...e42b08d. Read the comment docs.

@yangaws yangaws merged commit 5b18ce4 into aws:master Nov 15, 2018
@laurenyu laurenyu deleted the fix-changelog branch November 15, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants